Bug fix for use-after-close connection in AXFR #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #522
@smeinecke Thank you for the thorough bug report, made it a lot easier to debug.
On inspection with
git bisectthis was caused by the CLI + Library refactor (c192044). In the old code, there was adns.Transferin everyRoutineLookupFactory, importantly, per-thread.In the new code, there was one in the
AXFRModulewhich is shared by multiple threads. The first lookup would have opened a connection and then closed it. The second lookup has logic that if the connection isnil, it'll open a new one. However if it is non-nil (but closed), it'll attempt to write. This resulted in the error.The fix is to have a connection per
Lookup(). Needed to use an interface factory so we can mock this in the unit tests.Testing