Resolving Issue #460 #544
Open
Resolving Issue #460 #544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inates + unit tests.
zakird
requested changes
Apr 24, 2025
There was a problem hiding this comment.
Hi! In this situation, I would add this as a new formatted coordinate string value and continue to provide the raw values since it'll be a pain to parse these out after the fact. Both could be useful in different situations. This will also make this a non-breaking change to the tool.
Also, I suspect already on your radar, but in case not, looks like tests are failing, which we'll need to get cleaned up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helper function to convert raw DNS LOC values to human readable coordinates. The conversion follows RFC 1876 section 3 for LOC record format.
Unit Tests includes: