Skip to content

Implements logs command #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

exkson
Copy link

@exkson exkson commented Mar 20, 2025

This PR implements logs command for ceph-devstack

Features

  • dump logs of most recent run
  • dump logs for specific run
  • configurable dir through ceph-devstack config path
  • support for specific job if there are many

@exkson exkson marked this pull request as ready for review March 20, 2025 23:31
@exkson exkson force-pushed the gsoc-2/implements-logs branch from 2fd5e62 to 2545620 Compare March 20, 2025 23:37
@exkson
Copy link
Author

exkson commented Mar 20, 2025

Hello @VallariAg @zmc @amathuria here is my proposal for logs command implementation on ceph-devstack. Looking forward to your feedback.

Copy link
Owner

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission! I like your approach overall. Aside from the specific comments I've made, I'd also like to point out the pathlib library that we use elsewhere in the project; it's quite an improvement over working with os.path!

@exkson exkson marked this pull request as draft April 16, 2025 19:11
@exkson exkson force-pushed the gsoc-2/implements-logs branch from 2545620 to 1474b7b Compare April 17, 2025 14:35
@exkson exkson marked this pull request as ready for review April 21, 2025 20:58
@exkson
Copy link
Author

exkson commented Apr 21, 2025

Hello @zmc, I've applied the suggestions. I’d appreciate your feedback when you have a moment. Thanks!

Copy link
Owner

@zmc zmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating based on my feedback - these are good changes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants