-
Notifications
You must be signed in to change notification settings - Fork 9
Implements logs command #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
2fd5e62
to
2545620
Compare
Hello @VallariAg @zmc @amathuria here is my proposal for logs command implementation on ceph-devstack. Looking forward to your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission! I like your approach overall. Aside from the specific comments I've made, I'd also like to point out the pathlib
library that we use elsewhere in the project; it's quite an improvement over working with os.path
!
2545620
to
1474b7b
Compare
Hello @zmc, I've applied the suggestions. I’d appreciate your feedback when you have a moment. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating based on my feedback - these are good changes :)
This PR implements
logs
command for ceph-devstackFeatures