[GSOC Taks 2] ceph-devstack Cli logs feature : To Display Teuthology Logs #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi4578
changed the title
abhi4578
changed the title
|
Hello @amathuria @VallariAg @zmc here is my gsoc task 2 logs command implementation on ceph-devstack. Looking forward to your feedback. |
|
Disclosure: Github Copilot was used to add doc-strings (like args of function docs/comments) and few one liner python exceptions. Please let me know if this is acceptable or needs to be changed accordingly? |
kamoltat
reviewed
Apr 9, 2025
|
@abhi4578 also can you please rebase your PR against the main branch thank you |
- ``ceph-devstack logs `` displays latest run teuthology logs of given job - ``ceph-devstack logs --log-file `` displace file location of latest run teuthology log of given job
Signed-off-by: Abhi <[email protected]>
Co-authored-by: Kamoltat (Junior) Sirivadhna <[email protected]> Signed-off-by: Abhi <[email protected]>
- Add appropriate comments for better understanding - Add try, except block while parsing latest job directory paths to catch ValueError - Make flag_set to boolean from str for simplicity in test_logs.py - Added chec condition if teuthology.log file exists before reading to prevent exceptions
- Also replace return statements with exit statements in test_logs.py file because pytest warnings
abhi4578
force-pushed
the
cli-feature/logs
branch
from
94f2a8f to
fe0f8b8
Compare
|
@kamoltat I have added commits resolving the above issues and rebased it against main branch. Please review. Find the screenshots of
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds implementation of logs and --logs-file option
ceph-devstack logsdisplays latest runteuthology logs of given job
ceph-devstack logs --log-filedisplaysfile location of latest run teuthology log of
given job
Adds pytest unit tests to test 'logs' command
test cases using parametrized tests and fixtures