-
Notifications
You must be signed in to change notification settings - Fork 0
Refactor #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AlexBecalick
wants to merge
19
commits into
master
Choose a base branch
from
refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Refactor #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also download other files in parts to prevent failed ftp downloads and check for existing files that are non .gz
…input to SLURM jobs
Add probe settings to the config file and add a cli command to run probe design in parallel on slurm
Added usage instructions for SLURM and local execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code has been reorganised into a set of submodules within the folder multi_padlock_design.
CLI entry points have been added which enable automatic download of BLAST databases and associated data, as well as ways to run the pipeline as parallel jobs on slurm or locally.
The README has been updated to reflect the new layout of the pipeline and how a user can interact with it.
I've tried to ensure all imports are fixed, even for the snail probe design but I haven't tested the snail probe side of things.
I have tested:
Known issue:
Giving a csv with more than one gene will break the local pipeline due to indexing errors. (Current extensions to the pipeline were built around the assumptions of running this always on SLURM for single genes per job).
This issue is listed here: #3
It doesn't affect the intended SLURM use of the pipeline, so I would suggest merging and then fixing this issue later (for external users who don't have access to HPC resources)