fix(e2e): wire PRODUCT_VERSION into chainsaw values#267
Merged
Conversation
CI sets PRODUCT_VERSION per matrix leg, but chainsaw only resolves ($values.*) bindings from files passed via --values, so ($values.product_version) was always null and every matrix leg silently tested the operator's default product version. Generate test/e2e/.values.yaml from PRODUCT_VERSION before running chainsaw and pass it via --values. When PRODUCT_VERSION is unset the file contains null, which preserves the previous fallback to the operator default. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The chainsaw e2e product-version matrix is dead. CI (
test.yml/release.yml) sets aPRODUCT_VERSIONenv var per matrix leg, and the chainsaw tests reference($values.product_version)in CR manifests (e.g.spec.image.productVersion). But chainsaw only populates$valuesfrom--valuesfiles, and thechainsaw-e2eMakefile target never passed one. As a result($values.product_version)always resolved tonull,productVersionserialized unset, and every matrix leg silently tested the operator'sDefaultProductVersionfromapi/v1alpha1/image.go.Fix
chainsaw-valuestarget that generatestest/e2e/.values.yamlfrom$PRODUCT_VERSION. When the variable is unset it writesproduct_version: null, which preserves the previous fallback to the operator default for local runs.--values test/e2e/.values.yamlinchainsaw-e2e(and inchart-e2ewhere present, so both chainsaw invocations resolve values consistently).Verification
Verified locally on zookeeper-operator against a kind cluster: generated the values file via
make chainsaw-valueswithPRODUCT_VERSION=3.9.3and ran thesmoke/cluster-operationchainsaw case with--values test/e2e/.values.yaml(the exact flags the patched target uses). The case passed (1 passed / 0 failed / 0 skipped), and the appliedZookeeperClusterCR carriedspec.image.productVersion: "3.9.3"explicitly — the field has no CRD default, so its presence proves the values wiring.🤖 Generated with Claude Code