API implementation for fetching posts ,comments and albums#15
Open
DarshanS4444 wants to merge 1 commit intoznsio:mainfrom
Open
API implementation for fetching posts ,comments and albums#15DarshanS4444 wants to merge 1 commit intoznsio:mainfrom
DarshanS4444 wants to merge 1 commit intoznsio:mainfrom
Conversation
mshahrukh2
reviewed
Jan 9, 2023
| Scenario: Get albums of user | ||
| Given def userId = 1 | ||
| And def checkUserIdInAlbums = karate.call('classpath:com/znsio/templates/albumsTemplates.feature@getAlbumsOfUser', {'userId' : userId}).checkUserIdInAlbums | ||
| Then assert checkUserIdInAlbums == true |
There was a problem hiding this comment.
Not a correct validation, here true meaning of templates is broken.
| @@ -0,0 +1,13 @@ | |||
| @prod @posts | |||
There was a problem hiding this comment.
Why you have taken separate feature files?
|
|
||
| Scenario: Get posts of user | ||
| Given def userId = 1 | ||
| And def checkUserIdInPosts = karate.call('classpath:com/znsio/templates/postsTemplates.feature@getPostsOfUser', {'userId' : userId}).checkUserIdInPosts |
There was a problem hiding this comment.
checkUserIdInPosts incorrect name of the variable. It doesn't represent what it contains.
| function(responseArray){ | ||
| for (let i = 0; i < responseArray.length; i++){ | ||
| if(responseArray[i].userId != userId) return false | ||
| else return true |
There was a problem hiding this comment.
This function is not required here, try to think of any other way .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.