Fix S/MIME certificate removal and messaging #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting S/MIME leaf certificate generates errors like ``` Delete private aborted, not possible to delete Secret: [...]P, No such file or directory! ``` because of redundant call to private key deleting function. UI messages generated by S/MIME operations are not translated and some of them are misleading. This mod fixes problem with redundant delete op, adds translations and fixes some S/MIME messages. Author-Change-Id: IB#1161112 Signed-off-by: Pawel Boguslawski <[email protected]>
Fixes: 0002b05 Author-Change-Id: IB#1161112 Signed-off-by: Pawel Boguslawski <[email protected]>
Author-Change-Id: IB#1161112 Signed-off-by: Pawel Boguslawski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Deleting S/MIME leaf certificate generates errors like
because of redundant call to private key deleting function (cert removal routine removes priv key already).
UI messages generated by S/MIME operations are not translated and some of them are misleading.
This mod fixes problem with redundant delete op, adds translations and fixes some S/MIME messages.
Type of change
Additional information
Author-Change-Id: IB#1161112## Checklist