Skip to content

ZMS-215: fix incorrect existsEntries and removeEntries clearing in updateMessage() #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NickOvt merged 2 commits into from
Apr 7, 2025
Merged

ZMS-215: fix incorrect existsEntries and removeEntries clearing in updateMessage() #803

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d19021
fix incorrect existsEntries and removeEntries clearing in updateMessa…
NickOvt Apr 7, 2025
1727c86
add clarifying comment
NickOvt Apr 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/message-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,7 @@ class MessageHandler {

// get target mailbox data
// get target user data
// if throws will be handled by caller or wrapper
let [mailboxData, userData] = await Promise.all([this.getMailboxAsync(options), this.users.collection('users').findOne({ _id: options.user })]);

if (!userData) {
Expand Down Expand Up @@ -2201,8 +2202,8 @@ class MessageHandler {
this.notifier.addEntries(mailboxData, removeEntries, () => {
// mark messages as added to new mailbox
this.notifier.addEntries(targetData, existsEntries, () => {
removeEntries = [];
existsEntries = [];
removeEntries.length = 0; // Clear top-level argument array, setting length to 0 clears array object
existsEntries.length = 0;
this.notifier.fire(mailboxData.user);
return resolve(true);
});
Expand Down
Loading