#277 Prevent EmbeddedDatabaseTestExecutionListener from affecting non-annotated tests #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-annotated tests
AndreKoepke
reviewed
Dec 3, 2024
| @@ -87,6 +87,10 @@ private void captureTestClassPreparers(TestContext testContext, RefreshMode... r | |||
| private void forEachDatabase(TestContext testContext, RefreshMode[] refreshModes, BiConsumer<DatabaseContext, AutoConfigureEmbeddedDatabase> action) { | |||
| Set<AutoConfigureEmbeddedDatabase> annotations = AnnotationUtils.getDatabaseAnnotations(testContext.getTestClass()); | |||
|
|
|||
| if (annotations.isEmpty()) { | |||
There was a problem hiding this comment.
I'm not sure if this brings any difference, because it is only used in a .forEach() part. A .forEach() on a empty Set will already do nothing.
There was a problem hiding this comment.
The real issue was in calling the testContext.getApplicationContext() method below. This method call could trigger eager initialization of Spring context, even without presence of the @AutoConfigureEmbeddedDatabase annotation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.