Pages Editor: remove "Workflows belongs to Project" checks

[shaunanoordin]

PR Overview

Fixes #7343
Affects: Pages Editor (aka Workflow Editor)

This PR fixes an issue where newly-created workflows aren't correctly identified as being part of the project. This means the Pages Editor no longer checks if the workflow belongs to a project before allowing users to edit the workflow.

The "workflow belongs to project" check was initially added as a safety against a niche scenario, but it seems to be causing more problems than it's solving.

Testing

Testing is a bit difficult, so don't worry about it too much since this only affects the new Pages Editor (aka Workflow Editor) and NOT the standard PFE Project Builder page for editing workflows.

But if you really want to...

Basic test for Pages Editor:

• (no change) You should be able to access a Workflow (made with Pages Editor) that belongs to the correct Project, e.g. https://pr-7344.pfe-preview.zooniverse.org/lab/1982/workflows/editor/3711?env=staging (use zootester2)
• (no change) You should not be able to access a Workflow not made with Pages Editor, regardless of whether it belongs to the correct project, e.g. https://pr-7344.pfe-preview.zooniverse.org/lab/1982/workflows/editor/3739?env=staging (use zootester2. Error message is "Sorry, but the new workflow editor doesn't support traditional workflows.")

Specific tests for PR:

• 🆕 You should be able to access a Workflow (made with Pages Editor) that belongs to a different Project, IF you have permissions/access to that Project AND that Workflow. e.g. https://pr-7344.pfe-preview.zooniverse.org/lab/2023/workflows/editor/3711?env=staging (use zootester2)
• (no change) You should NOT be able to access a Workflow (made with Pages Editor) that belongs to a different project, IF you lack permissions/access for that Project. (You'd just get a "you don't have permission to edit this project" before you can do anything.) e.g. https://pr-7344.pfe-preview.zooniverse.org/lab/1873/workflows/editor/3711?env=staging (use zootester2)
• (no change) You should NOT be able to EDIT a Workflow (made with Pages Editor) that belongs to a different project, IF you lack permissions/access for that Workflow. (You should still be able to see the Workflow though.) e.g. https://pr-7344.pfe-preview.zooniverse.org/lab/2023/workflows/editor/3711?env=staging (use zootester1) (NOTE: there's no error message and it looks like you can make changes, but you just need to refresh the page to show that nothing was saved.)

The problem with running these tests is that I had to set up two different projects with two different user accounts, which was a pain to do properly. 😬 You'd either need to trust me that I set up the workflows and zootester1/2 permissions properly, or you'll need to replicate the permissions etc correctly. Trying to test any of the above with our standard admin mode enabled will just bypass a bunch of the permission checks anyway.

Status

Low priority, ready for review.

[coveralls]

coverage: 55.943% (-0.02%) from 55.961%
when pulling 336cf7c on fix-7343-pages-editor
into 23e506b on main.

[shaunanoordin]

@zooniverse/frontend please take a look at my PR thanks!

(I'm actually testing the @ system)