Include ZTK versions and run their tests here.#97
Merged
Conversation
So we no longer depend on ZTK releases to see updates of these versions.
There was a problem hiding this comment.
Pull Request Overview
This PR embeds Zope Toolkit (ZTK) version pins and source references directly into the GROK toolkit repo and updates test commands to use a unified test environment. Key changes include:
- Renamed test environment from
test-groktotestacross configs and tox. - Inlined ZTK package lists in
grok.cfg,grok-versions.cfg, andgrok-sources.cfgfor local version management. - Updated documentation to remove external ZTK version checks and added an unreleased “5.5” changelog entry.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tox.ini | Switched command from test-grok to test. |
| grok.cfg | Removed remote ZTK versions include; added ZTK packages. |
| grok-versions.cfg | Added pinned ZTK and dependency versions; extended Python sections. |
| grok-sources.cfg | Added ZTK Git source entries for each package. |
| docs/release.rst | Dropped instructions to externally check ZTK versions. |
| docs/changes.rst | Added “5.5 (unreleased)” changelog entry. |
| buildout.cfg | Renamed [test-grok] part to [test]. |
| .meta.toml | Updated test-grok command to test. |
Comments suppressed due to low confidence (4)
docs/changes.rst:4
- [nitpick] Consider adding a placeholder release date (e.g.,
YYYY-MM-DD) or a note to fill in the date once 5.5 is released, matching the format used in earlier entries.
5.5 (unreleased)
buildout.cfg:7
- You’ve renamed the buildout part from
test-groktotest; ensure that all CI workflows and scripts referencingtest-grokare updated accordingly to prevent broken build steps.
test
.meta.toml:18
- The meta config now calls
testinstead oftest-grok; verify any tooling or README instructions that reference the old command are also updated.
"{envdir}/bin/test {posargs:-cv}",
grok-versions.cfg:2
- [nitpick] The large, duplicated ZTK package lists in
grok.cfg,grok-versions.cfg, andgrok-sources.cfgmay become hard to sync manually; consider generating or centralizing this list via a script or common include to reduce drift.
# ZTK
janjaapdriessen
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we no longer depend on ZTK releases to see updates of these versions.