Skip to content

Include ZTK versions and run their tests here.#97

Merged
icemac merged 2 commits intomasterfrom
merge-with-ZTK
Jun 17, 2025
Merged

Include ZTK versions and run their tests here.#97
icemac merged 2 commits intomasterfrom
merge-with-ZTK

Conversation

@icemac
Copy link
Member

@icemac icemac commented Jun 17, 2025

So we no longer depend on ZTK releases to see updates of these versions.

So we no longer depend on ZTK releases to see updates of these versions.
@icemac icemac self-assigned this Jun 17, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR embeds Zope Toolkit (ZTK) version pins and source references directly into the GROK toolkit repo and updates test commands to use a unified test environment. Key changes include:

  • Renamed test environment from test-grok to test across configs and tox.
  • Inlined ZTK package lists in grok.cfg, grok-versions.cfg, and grok-sources.cfg for local version management.
  • Updated documentation to remove external ZTK version checks and added an unreleased “5.5” changelog entry.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tox.ini Switched command from test-grok to test.
grok.cfg Removed remote ZTK versions include; added ZTK packages.
grok-versions.cfg Added pinned ZTK and dependency versions; extended Python sections.
grok-sources.cfg Added ZTK Git source entries for each package.
docs/release.rst Dropped instructions to externally check ZTK versions.
docs/changes.rst Added “5.5 (unreleased)” changelog entry.
buildout.cfg Renamed [test-grok] part to [test].
.meta.toml Updated test-grok command to test.
Comments suppressed due to low confidence (4)

docs/changes.rst:4

  • [nitpick] Consider adding a placeholder release date (e.g., YYYY-MM-DD) or a note to fill in the date once 5.5 is released, matching the format used in earlier entries.
5.5 (unreleased)

buildout.cfg:7

  • You’ve renamed the buildout part from test-grok to test; ensure that all CI workflows and scripts referencing test-grok are updated accordingly to prevent broken build steps.
  test

.meta.toml:18

  • The meta config now calls test instead of test-grok; verify any tooling or README instructions that reference the old command are also updated.
    "{envdir}/bin/test {posargs:-cv}",

grok-versions.cfg:2

  • [nitpick] The large, duplicated ZTK package lists in grok.cfg, grok-versions.cfg, and grok-sources.cfg may become hard to sync manually; consider generating or centralizing this list via a script or common include to reduce drift.
# ZTK

@icemac icemac enabled auto-merge (squash) June 17, 2025 14:56
@icemac icemac merged commit 94ef147 into master Jun 17, 2025
14 checks passed
@icemac icemac deleted the merge-with-ZTK branch June 17, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants