Drop cache action restore-keys to prevent bad cache hits#417
Merged
Drop cache action restore-keys to prevent bad cache hits#417
restore-keys to prevent bad cache hits#417Conversation
Coverage Report for CI Build 25207206589Coverage remained the same at 14.851%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
icemac
approved these changes
May 5, 2026
Member
icemac
left a comment
icemac
left a comment
There was a problem hiding this comment.
Yes, let's get rid of the restore keys I am not sure why we had them in the first place. Might be helpful in Python only project but even there probably not always.
Member
Author
|
I bet it was simply copy-pasted from example code in the cache action documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As observed in several places like zopefoundation/zope.security#128 the
restore-keyssetting can lead to wrong caches used.The line break at the end of the file is on purpose to reduce visual clutter in the resulting tests configuration.