Skip to content

ZODBReference is now callable to fix an unpickling error #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ale-rt wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ZODBReference is now callable to fix an unpickling error #40

ale-rt wants to merge 1 commit into from

Conversation

@ale-rt
Copy link
Member

@ale-rt ale-rt commented Sep 16, 2020

Fixes #20

@jamadden
Copy link
Member

jamadden commented Sep 16, 2020

Is there the possibility of adding a failing test case (without this change)?

@ale-rt
Copy link
Member Author

ale-rt commented Sep 16, 2020

Unfortunately I have no idea how this can be tested :)
During the DB migration the newly added __call__ function is never called.
The new pickle and the old pickle look similar.
The object (/Plone/acl_users) is accessible through the ZMI and its children are accessible as well.

@icemac
Copy link
Member

icemac commented Feb 8, 2023

Is this PR still valid?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AttributeError: 'ZODBReference' object has no attribute '__bases__'

4 participants

@ale-rt @jamadden @icemac