Skip to content

Sync up doctest code that generates samples#19

Merged
icemac merged 2 commits intozopefoundation:masterfrom
cjwatson:update-samples-properly
Feb 9, 2026
Merged

Sync up doctest code that generates samples#19
icemac merged 2 commits intozopefoundation:masterfrom
cjwatson:update-samples-properly

Conversation

@cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Feb 9, 2026

7a7947c made minor adjustments to several sample files, but didn't update the doctest that generates them. Debian's reproducible builds machinery happened to notice that they were out of sync (https://bugs.debian.org/1123664).

  • I signed and returned the Zope Contributor Agreement, and received and accepted an invitation to join a team in the zopefoundation GitHub organization.
  • I verified there aren't any other open pull requests for the same change.
  • I followed the guidelines in Developer guidelines.
  • I successfully ran code quality checks on my changes locally.
  • I successfully ran tests on my changes locally.
  • I included a change log entry in my commits.

7a7947c made minor adjustments to
several sample files, but didn't update the doctest that generates them.
Debian's reproducible builds machinery happened to notice that they were
out of sync (https://bugs.debian.org/1123664).
@cjwatson
Copy link
Contributor Author

cjwatson commented Feb 9, 2026

#20 fixes the pre-commit workflow failure seen here.

Copy link
Member

@icemac icemac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the PR, was wondering about the changed files after a test run. Thank you for cleaning this up.

@icemac icemac enabled auto-merge (squash) February 9, 2026 08:14
@icemac icemac merged commit 3f837fd into zopefoundation:master Feb 9, 2026
10 checks passed
@icemac
Copy link
Member

icemac commented Feb 9, 2026

cjwatson added a commit to cjwatson/zope.deferredimport that referenced this pull request Feb 13, 2026
This is similar to zopefoundation#19, but Debian's reproducible builds machinery noticed that
even after that work I'd still missed a few blank lines.
icemac pushed a commit that referenced this pull request Feb 16, 2026
This is similar to #19, but Debian's reproducible builds machinery noticed that
even after that work I'd still missed a few blank lines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants