Skip to content

transcoder: update echov5#1358

Draft
acelinkio wants to merge 1 commit intozoriya:masterfrom
acelinkio:echov5
Draft

transcoder: update echov5#1358
acelinkio wants to merge 1 commit intozoriya:masterfrom
acelinkio:echov5

Conversation

@acelinkio
Copy link
Collaborator

marking as draft: Application starts, however I need to check a few things. my lab might be having issues.

@acelinkio
Copy link
Collaborator Author

IDE complained about what part of code i'm not familar with. unused write to field Keyframes.. i've tried with original code (and what is checked in right now)

	if ret.Versions.Keyframes < KeyframeVersion && ret.Versions.Keyframes != 0 {
		for _, video := range ret.Videos {
			video.Keyframes = nil
		}
		for _, audio := range ret.Audios {
			audio.Keyframes = nil
		}

attempted to resolve with AI help

if ret.Versions.Keyframes < KeyframeVersion && ret.Versions.Keyframes != 0 {
    for i := range ret.Videos {
        ret.Videos[i].Keyframes = nil
    }
    for i := range ret.Audios {
        ret.Audios[i].Keyframes = nil
    }

In both cases, an issue came up that appears to be related to my lab. transcoder shows logs that its processing. Ui shows the loading bar. Might be some slowness in my network/storage. Might be a known issue with the build. Will debug what is happening in the next couple days.

res, err := resource.New(
ctx,
resource.WithAttributes(semconv.ServiceNameKey.String("kyoo.transcoder")),
resource.WithAttributes(semconv.ServiceNameKey.String("kyoo.auth")),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds like an error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants