Adding unaggregated parameter to events.GetEvents - #203
Open
EricByers wants to merge 3 commits into
Open
Conversation
Collaborator
|
@EricByers hey 👋 thanks for sending the PR. I'd much rather have a new method, e.g. The old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for
unaggregatedparameter for query events.See: https://docs.datadoghq.com/api/?lang=python#query-the-event-stream
This change is not backwards compatible as it changes the function signature. This function could potentially be rewritten to a variadiac to keep it backwards compatible if needed.Made the new parameter variadic, if more parameters are needed, there would need to be a breaking change (new param or switch to struct), or all the parameters would need to move to be variadic.