fix(ad_session): find_computer_by_sam_name to return ADComputer#93
Open
mponton-cn wants to merge 1 commit into
Open
fix(ad_session): find_computer_by_sam_name to return ADComputer#93mponton-cn wants to merge 1 commit into
mponton-cn wants to merge 1 commit into
Conversation
Contributor
Author
|
@zorn96 thanks for the great library by the way! Much appreciated. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed
find_computer_by_sam_namewas returning the wrong type trying to calloverwrite_attribute_for_computerusing the output of said find function.