Improve the xmltojson.py script#42
Open
rudolfbyker wants to merge 4 commits into
Open
Conversation
rudolfbyker
commented
Jul 2, 2021
rudolfbyker
commented
- Follow PEPs.
- Clean up imports.
- Separation of concerns and better code reuse by splitting up into functions.
- Make silent by default, but add 'verbose' flag.
- Use a context manager when writing a file, to prevent leaking file descriptors.
Author
|
@dstillman @northword would you prefer that I split this into smaller PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.