Skip to content

include annotation tags for /collections/:key/tags #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abaevbog wants to merge 3 commits into
base: master
Choose a base branch
from
Open

include annotation tags for /collections/:key/tags #163

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3be75e0
include annotation tags for /collections/:key/tags
abaevbog Aug 21, 2023
e3a4438
in /top mode, use top level itemID in tag filter
abaevbog Aug 22, 2023
7453f3c
minor syntax fixes
abaevbog Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions model/Collection.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,6 +629,24 @@ public function getTagItemCounts() {
foreach ($rows as $row) {
$counts[$row['tagID']] = $row['numItems'];
}
// Fetch the tags of annotations as well
$annotationsSql = "SELECT tagID, COUNT(*) AS numItems FROM tags JOIN itemTags USING (tagID)

@dstillman dstillman Aug 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JOIN on next line, but I guess we technically don't need tags here or above, so could just remove that.

JOIN itemAnnotations USING (itemID)
JOIN itemAttachments ON itemAttachments.itemID = itemAnnotations.parentItemID
JOIN collectionItems ON collectionItems.itemID = itemAttachments.sourceItemID

@dstillman dstillman Aug 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

House style: parens around the expression for consistency with USING, even though it's not required for ON

WHERE collectionID=? GROUP BY tagID;";

@dstillman dstillman Aug 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No semicolon needed


$rows = Zotero_DB::query($annotationsSql, $this->id, Zotero_Shards::getByLibraryID($this->libraryID));
if (!$rows) {
return $counts;
}
// Add numItems into the same array.
foreach ($rows as $row) {
if (!array_key_exists($row['tagID'], $counts)) {
$counts[$row['tagID']] = 0;
}
$counts[$row['tagID']] += $row['numItems'];
}
return $counts;
}

Expand Down