Improve search performance#68
Merged
Merged
Conversation
Contributor
Author
|
try to notify @mrtcode so that we don't forget this fix, as people are distributing their own fix to this with their modified version of my plugin, which is not very ideal... |
Member
|
This is a great improvement to the search performance! Just need to figure out why the scroll listener doesn't update the decorations, and the yellow highlights appear only if clicked on the text. |
Use debounce for searching Only render decorations within view range
windingwind
force-pushed
the
fix-slow-search
branch
from
4da9ae9 to
b8703d9
Compare
Contributor
Author
|
Thanks! Should be fixed now. |
Contributor
Author
Screen.Recording.2026-01-12.at.15.00.02.mp4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use debounce for searching
Only render decorations within view range
Other minor fixes for efficiency
For note with 100k words, before fix it hangs for over 1 minute for searching a single char
t, now stably <100ms. Test on MacOS with M2proCan test with the book DRACULA: https://gutenberg.org/files/345/345-h/345-h.htm (create note - select all on website - copy - paste - search - type
t)