Support async itemDone on child translator#29
Open
AbeJellinek wants to merge 1 commit into
Open
Conversation
|
Thank you - this will make writing translator code much easier. Right now quite a lot of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@zoe-translates pointed out that you can't set an async
itemDonehandler on a child translator, likeInstead, that code will cause translation to fail (no items returned) when it awaits the HTTP request.
It looks like we already support async handlers (in most cases, at least!). We just weren't awaiting handlers set on child
safeTranslators, nor were we incrementing/decrementing async processes in order to wait for theitemDonehandler to complete when the child translator doesn't awaitItem#complete(). This PR fixes those two issues. Client translation tests are passing.