Skip to content

request(): Improve validation and allow/return more#39

Open
AbeJellinek wants to merge 1 commit into
zotero:masterfrom
AbeJellinek:request-validation-and-options
Open

request(): Improve validation and allow/return more#39
AbeJellinek wants to merge 1 commit into
zotero:masterfrom
AbeJellinek:request-validation-and-options

Conversation

@AbeJellinek
Copy link
Copy Markdown
Member

  • Validate responseType - some underlying implementations may allow more values (arraybuffer), but we only support three when calling from a translator
  • Allow URL object as url argument
  • Accept successCodes
    • This was an oversight when originally implementing this function. Useful and we should support it!
  • Return statusText and responseURL for more complex use cases

@AbeJellinek AbeJellinek requested a review from dstillman December 4, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant