Add necessary utilities for generic translators#20
Conversation
dstillman
left a comment
There was a problem hiding this comment.
jsonld.js is this? Is this built fresh or just pulled from node_modules/dist/jsonld.js after an npm i jsonld?
In the Connector, do we know if this (large) file gets injected into each webpage/sandbox, or does it just get loaded in the background page/service worker? (@adomasven might be able to comment on this.)
|
Built fresh. I could add a script to zotero/zotero to do the build if you'd like. It's essentially just |
|
Yeah, for a large, modified third-party file, particularly one that has to be included in the browser extensions, it's better when we can point to a build script — e.g., so that we can point to that if a reviewer complains about it. (They really prefer unmodified files, but I guess that's not an option here.) Should we just make the |
|
OK, script added. |
Causes a stack overflow due to circular references when being copied into the sandbox. We should probably make SandboxManager#importObject() deal with circular references without blowing up, but this works for now.
5bcca52 to
7b7f96d
Compare
Replaces zotero/zotero#1656