Migrate to ESM#45
Open
tobiasdiez wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've migrated the whole codebase to ESM (including updating package metadata, converting core modules and tests, and refreshing the README examples for ESM imports).
Moving to ESM matches modern Node/browser module semantics, and down the road enables tree-shaking and better static analysis.
I should note that this is a breaking change as one cannot
requirean ESM module. Normally, this is addressed by having a bundler (like rollup) emit CJS and ESM at the same time, and ship that. But the other Zotero projects are just including this repo verbatim, so this is not really an option. On the other hand, one has to start with the migration somewhere and the utilities (and later translator) repo is a good starting point.