-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: expect resposne code for positive cases #3990
base: v3.x.x
Are you sure you want to change the base?
Conversation
Signed-off-by: ac892247 <[email protected]>
Signed-off-by: ac892247 <[email protected]>
@@ -31,7 +31,7 @@ public class InMemoryRateLimiterFilterFactoryIntegrationTest { | |||
|
|||
private static WebTestClient client; | |||
|
|||
final int bucketCapacity = 60; | |||
final int bucketCapacity = 20; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this number was specified for HA integration tests, could you verify this branch with the ITs pipeline?
If it needs to be updated we should have it parameterized depending on whether it's run as HA or single instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @taban03
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, in our HA ITs it was failing, because the calls are routed randomly to different GW instances and the rate limit is set on instance level so it might never reach this limit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's now configurable via "gateway.bucketCapacity." I'm not sure if that would solve your problem with HA, as it can still be random, and you will not get the exact number of requests for each instance. It was probably passing due to missing the lower boundary check.
|
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline