- 
                Notifications
    You must be signed in to change notification settings 
- Fork 16
Fetch multiple resource types in ResourceContainer #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            AndrewTwydell
  wants to merge
  2
  commits into
  main
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
resource-fetcher
  
      
      
   
  
    
  
  
  
 
  
      
    base: main
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | Codecov Report❌ Patch coverage is  Additional details and impacted files@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   68.24%   69.15%   +0.90%     
==========================================
  Files         165      164       -1     
  Lines        3883     3932      +49     
  Branches      549      546       -3     
==========================================
+ Hits         2650     2719      +69     
+ Misses       1233     1213      -20     ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
2b4a169    to
    fa12ea9      
    Compare
  
    85f8c75    to
    cde8832      
    Compare
  
    fa12ea9    to
    2825e52      
    Compare
  
    46d7cfa    to
    0676a9e      
    Compare
  
    2825e52    to
    74014a1      
    Compare
  
    0676a9e    to
    c6e342e      
    Compare
  
    74014a1    to
    f9d2576      
    Compare
  
    daf1aab    to
    3c9676c      
    Compare
  
    581de8a    to
    73a76c3      
    Compare
  
    3c9676c    to
    fea7f65      
    Compare
  
    1476518    to
    8a195fd      
    Compare
  
    fea7f65    to
    e9257c8      
    Compare
  
    8a195fd    to
    8600e32      
    Compare
  
    e9257c8    to
    f8d7c4f      
    Compare
  
    a7be061    to
    cae8b74      
    Compare
  
    Signed-off-by: Andrew Twydell <[email protected]>
Signed-off-by: Andrew Twydell <[email protected]>
cae8b74    to
    b4366fe      
    Compare
  
    
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
What It Does
Allows multiple resource types to be fetched with a single ResourceContainer, allowing multiple resources under the same parent tree. It also proportionally shares the page count between the resource types.
eg, if there were 2000 Local Files and 1000 Remote files under a single Files tree, with a page count of 300, each page would contain 200 local files and 100 remote files.
Review Checklist
I certify that I have:
Additional Comments