Skip to content

Conversation

@AndrewTwydell
Copy link
Contributor

What It Does
Allows multiple resource types to be fetched with a single ResourceContainer, allowing multiple resources under the same parent tree. It also proportionally shares the page count between the resource types.

eg, if there were 2000 Local Files and 1000 Remote files under a single Files tree, with a page count of 300, each page would contain 200 local files and 100 remote files.

Review Checklist
I certify that I have:

  • tested my changes
  • added/updated automated tests
  • updated the changelog
  • considered whether the docs need updating
  • followed the contribution guidelines

Additional Comments

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2025

Codecov Report

❌ Patch coverage is 81.94444% with 52 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.15%. Comparing base (e94e9ec) to head (b4366fe).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/vsce/src/commands/showLibraryCommand.ts 9.09% 10 Missing ⚠️
...ckages/vsce/src/commands/filterResourceCommands.ts 14.28% 6 Missing ⚠️
packages/vsce/src/trees/CICSTree.ts 50.00% 6 Missing ⚠️
...s/vsce/src/commands/inspectResourceCommandUtils.ts 33.33% 4 Missing ⚠️
packages/vsce/src/resources/ResourceContainer.ts 95.83% 4 Missing ⚠️
packages/vsce/src/utils/treeUtils.ts 60.00% 4 Missing ⚠️
packages/vsce/src/trees/CICSPlexTree.ts 81.25% 3 Missing ⚠️
packages/vsce/src/trees/CICSSessionTree.ts 57.14% 3 Missing ⚠️
...ckages/vsce/src/commands/getFilterPlexResources.ts 0.00% 2 Missing ⚠️
packages/vsce/src/commands/inquireProgram.ts 33.33% 2 Missing ⚠️
... and 6 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   68.24%   69.15%   +0.90%     
==========================================
  Files         165      164       -1     
  Lines        3883     3932      +49     
  Branches      549      546       -3     
==========================================
+ Hits         2650     2719      +69     
+ Misses       1233     1213      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zowe-robot zowe-robot moved this from New Issues to In Progress in Zowe Explorer for VS Code Oct 15, 2025
@AndrewTwydell AndrewTwydell force-pushed the replace-resource-in-place branch from 2b4a169 to fa12ea9 Compare October 16, 2025 14:48
@AndrewTwydell AndrewTwydell force-pushed the replace-resource-in-place branch from fa12ea9 to 2825e52 Compare October 17, 2025 16:17
@AndrewTwydell AndrewTwydell force-pushed the resource-fetcher branch 3 times, most recently from 46d7cfa to 0676a9e Compare October 21, 2025 11:44
@AndrewTwydell AndrewTwydell force-pushed the replace-resource-in-place branch from 2825e52 to 74014a1 Compare October 21, 2025 14:46
@AndrewTwydell AndrewTwydell force-pushed the replace-resource-in-place branch from 74014a1 to f9d2576 Compare October 21, 2025 14:49
@AndrewTwydell AndrewTwydell force-pushed the resource-fetcher branch 2 times, most recently from daf1aab to 3c9676c Compare October 23, 2025 10:06
@AndrewTwydell AndrewTwydell force-pushed the replace-resource-in-place branch from 581de8a to 73a76c3 Compare October 23, 2025 10:59
@AndrewTwydell AndrewTwydell force-pushed the replace-resource-in-place branch 5 times, most recently from 1476518 to 8a195fd Compare October 28, 2025 15:52
@AndrewTwydell AndrewTwydell force-pushed the replace-resource-in-place branch from 8a195fd to 8600e32 Compare October 28, 2025 23:41
Base automatically changed from replace-resource-in-place to main October 29, 2025 14:53
@AndrewTwydell AndrewTwydell force-pushed the resource-fetcher branch 2 times, most recently from a7be061 to cae8b74 Compare October 29, 2025 15:17
@AndrewTwydell AndrewTwydell marked this pull request as ready for review October 29, 2025 15:28
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Review/QA

Development

Successfully merging this pull request may close these issues.

3 participants