show-bundle-in-uss-dir #473

Khushboo-Sharma-110597 · 2025-10-29T05:23:38Z

What It Does
#474

Review Checklist
I certify that I have:

tested my changes
added/updated automated tests
updated the changelog
considered whether the docs need updating
followed the contribution guidelines

Signed-off-by: Khushboo <[email protected]>

codecov-commenter · 2025-10-29T05:28:28Z

Codecov Report

❌ Patch coverage is 78.37838% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.47%. Comparing base (e94e9ec) to head (01ea643).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
packages/vsce/src/utils/commandUtils.ts	79.03%	13 Missing ⚠️
...es/vsce/src/commands/showBundleDirectoryCommand.ts	76.59%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #473      +/-   ##
==========================================
+ Coverage   68.24%   68.47%   +0.22%     
==========================================
  Files         165      166       +1     
  Lines        3883     3949      +66     
  Branches      549      562      +13     
==========================================
+ Hits         2650     2704      +54     
- Misses       1233     1245      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Khushboo <[email protected]>

packages/vsce/src/utils/commandUtils.ts

Signed-off-by: Khushboo <[email protected]>

Signed-off-by: Khushboo Sharma <[email protected]>

packages/vsce/__tests__/__unit__/commands/showBundleDirectoryCommand.unit.test.ts

Signed-off-by: Khushboo Sharma <[email protected]>

Signed-off-by: Khushboo <[email protected]>

Removed a problematic test case that was causing issues. Signed-off-by: Khushboo Sharma <[email protected]>

Khushboo-Sharma-110597 · 2025-10-31T06:12:47Z

I was considering writing an end-to-end test for this, but since the USS tree isn’t part of our extension, I couldn’t find the API calls related to it. I don’t think it’s feasible for us to write an e2e test in this case. From what I observed, they seem to be using environment variables to load data and possibly relying on real test data. Let me know your thoughts.@AndrewTwydell @davenice

davenice · 2025-10-31T07:15:50Z

I was considering writing an end-to-end test for this, but since the USS tree isn’t part of our extension, I couldn’t find the API calls related to it. I don’t think it’s feasible for us to write an e2e test in this case. From what I observed, they seem to be using environment variables to load data and possibly relying on real test data. Let me know your thoughts.@AndrewTwydell @davenice

Hi Khushboo, for an e2e test we'd be mocking exactly what happens on the wire, using wiremock.

So we'd look at which URLs were requested from wiremock, and then mock those using httpie or similar to get the date. We'd want to mock the minimum of their REST API that we could get away with!

You could investigate by adding localhost:8080, or wherever your wiremock is listening, as a zosmf connection and seeing which zosmf calls wiremock complains it doesn't have a mock for. You might need to start wiremock in verbose mode to see full details, I can't quite remember!

Khushboo-Sharma-110597 · 2025-10-31T07:40:37Z

I was considering writing an end-to-end test for this, but since the USS tree isn’t part of our extension, I couldn’t find the API calls related to it. I don’t think it’s feasible for us to write an e2e test in this case. From what I observed, they seem to be using environment variables to load data and possibly relying on real test data. Let me know your thoughts.@AndrewTwydell @davenice

Hi Khushboo, for an e2e test we'd be mocking exactly what happens on the wire, using wiremock.

So we'd look at which URLs were requested from wiremock, and then mock those using httpie or similar to get the date. We'd want to mock the minimum of their REST API that we could get away with!

You could investigate by adding localhost:8080, or wherever your wiremock is listening, as a zosmf connection and seeing which zosmf calls wiremock complains it doesn't have a mock for. You might need to start wiremock in verbose mode to see full details, I can't quite remember!

I can set up a WireMock server for z/OSMF, but adding REST API mappings is challenging because we can’t trace the z/OSMF calls using a TCP/IP debugger—the connection uses HTTPS.

davenice · 2025-10-31T08:03:44Z

That does make it a bit harder.

I think we could use the same wiremock server.

If you add your wiremock server as a zosmf connection and then try to use it, you will see from the wiremock output which URL was requested and failed. Then you could request the same kind of URL on a real server to see what comes back to put in your mock.

Another option would be to find a way to add some debug to Zowe explorer to output the request before it's made, but this sounds quite a lot of work for what I suspect will only be a few requests to be mocked.

Remember that we don't need a fully working wiremock, we don't even need the whole scenario to work properly. We just want to make sure that the call we make to Zowe explorer triggers zosmf to look for information correctly. This protects us against them changing their API in the future and breaking us.

AndrewTwydell

Looks good and works well! Couple of suggestions 👍🏼

AndrewTwydell · 2025-10-31T10:59:57Z

packages/vsce/package.json

        },
+        {
+          "command": "cics-extension-for-zowe.showBundleDirectory",
+          "when": "config.zowe.cics.showAllCommandsInPalette"


I don't think we use this feature toggle anymore...

Suggested change

"when": "config.zowe.cics.showAllCommandsInPalette"

"when": "never"

AndrewTwydell · 2025-10-31T11:03:08Z

packages/vsce/src/utils/commandUtils.ts

      return;
    }
-
+    


Suggested change

AndrewTwydell · 2025-10-31T11:06:06Z

packages/vsce/src/utils/commandUtils.ts

+ * @param connectionType - The type of connection to check for ('uss' or 'jes'), case-insensitive
+ * @returns True if the profile supports the specified connection type, false otherwise
+ */
+export function doesProfileSupportConnectionType(profile: IProfileLoaded, connectionType: string): boolean {


Could strongly type this so the developer calling it can ctrl + space to autocomplete - keeps things type safe 😄

Suggested change

export function doesProfileSupportConnectionType(profile: IProfileLoaded, connectionType: string): boolean {

export function doesProfileSupportConnectionType(profile: IProfileLoaded, connectionType: "JES" | "USS"): boolean {

Ah ZE have a ZoweExplorerApiType enum that we could use in @zowe/zowe-explorer-api...

Suggested change

export function doesProfileSupportConnectionType(profile: IProfileLoaded, connectionType: string): boolean {

export function doesProfileSupportConnectionType(profile: IProfileLoaded, connectionType: ZoweExplorerApiType): boolean {

So the method call would be

doesProfileSupportConnectionType(myProfile, ZoweExplorerApiType.Jes); doesProfileSupportConnectionType(myProfile, ZoweExplorerApiType.Uss); ... switch (type) { case ZoweExplorerApiType.Uss: explorerApi.getUssApi(profile); break; ...

AndrewTwydell · 2025-10-31T11:29:35Z

packages/vsce/src/commands/showBundleDirectoryCommand.ts

+            window.showErrorMessage(`No Bundle is selected from cics tree`);
+            return;
+        }
+        const bundleDir = selectedBundle.getContainedResource().resource.attributes?.bundledir;


Contained Resource is optional, but attributes is not

Suggested change

const bundleDir = selectedBundle.getContainedResource().resource.attributes?.bundledir;

const bundleDir = selectedBundle.getContainedResource()?.resource.attributes.bundledir;

AndrewTwydell · 2025-10-31T11:30:11Z

packages/vsce/src/commands/showBundleDirectoryCommand.ts

+        }
+        const bundleDir = selectedBundle.getContainedResource().resource.attributes?.bundledir;
+        if (!bundleDir) {
+            window.showErrorMessage(`Could not find bundle directory for ${selectedBundle.getLabel()


Suggested change

window.showErrorMessage(`Could not find bundle directory for ${selectedBundle.getLabel()

window.showErrorMessage(`Could not find bundle directory for ${selectedBundle.getContainedResourceName()

The label could have other info in that's not necessary here, status info for example

AndrewTwydell · 2025-10-31T11:41:54Z

packages/vsce/src/commands/showBundleDirectoryCommand.ts

+        if (!chosenProfileName) {
+            window.showErrorMessage("Could not find any profiles that will access USS (for instance z/OSMF).");
+            return;
+        }


If I am prompted for a profile because we went into line 78, and I clicked esc to cancel when choosing, I then get this error message which shouldn't be the case. If a user cancels out of an action, it should just exit quietly.

github-project-automation bot added this to Zowe Explorer for VS Code Oct 29, 2025

github-project-automation bot moved this to New Issues in Zowe Explorer for VS Code Oct 29, 2025

zowe-robot moved this from New Issues to In Progress in Zowe Explorer for VS Code Oct 29, 2025

github-actions bot assigned Khushboo-Sharma-110597 Oct 29, 2025

Khushboo-Sharma-110597 force-pushed the navigate-bundle-from-resource-to-USS branch from 09c0bff to cb24f53 Compare October 29, 2025 05:24

show-bundle-in-uss-dir

fe8e7ae

Signed-off-by: Khushboo <[email protected]>

Khushboo-Sharma-110597 force-pushed the navigate-bundle-from-resource-to-USS branch from cb24f53 to fe8e7ae Compare October 29, 2025 05:25

show-dir-in-uss

9c11a4b

Signed-off-by: Khushboo <[email protected]>

github-advanced-security bot found potential problems Oct 29, 2025

View reviewed changes

packages/vsce/src/utils/commandUtils.ts Fixed Show fixed Hide fixed

Khushboo-Sharma-110597 added 4 commits October 29, 2025 15:14

show-bundle-dir-changes

7be7362

Signed-off-by: Khushboo <[email protected]>

show-bundle-dir-changes

b486bd5

Signed-off-by: Khushboo <[email protected]>

show-bundle-dir

00219e8

Signed-off-by: Khushboo <[email protected]>

remove-multi-selecy

b8360ef

Signed-off-by: Khushboo <[email protected]>

Khushboo-Sharma-110597 added the no-changelog label Oct 30, 2025

Khushboo-Sharma-110597 added 2 commits October 30, 2025 14:39

unit-tests-added

6ef23e8

Signed-off-by: Khushboo <[email protected]>

Merge branch 'main' into navigate-bundle-from-resource-to-USS

572b1bc

Signed-off-by: Khushboo Sharma <[email protected]>

github-advanced-security bot found potential problems Oct 30, 2025

View reviewed changes

packages/vsce/__tests__/__unit__/commands/showBundleDirectoryCommand.unit.test.ts Fixed Show fixed Hide fixed

Khushboo-Sharma-110597 added 4 commits October 30, 2025 14:47

Remove unused import from showBundleDirectoryCommand test

2fde404

Signed-off-by: Khushboo Sharma <[email protected]>

unit-tests-added

7d7863a

Signed-off-by: Khushboo <[email protected]>

unit-tests-added

130c31c

Signed-off-by: Khushboo <[email protected]>

test fix

01ea643

Removed a problematic test case that was causing issues. Signed-off-by: Khushboo Sharma <[email protected]>

Khushboo-Sharma-110597 marked this pull request as ready for review October 31, 2025 06:13

Khushboo-Sharma-110597 requested review from AndrewTwydell, chinmdas and davenice October 31, 2025 06:13

zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code Oct 31, 2025

AndrewTwydell reviewed Oct 31, 2025

View reviewed changes

	"when": "config.zowe.cics.showAllCommandsInPalette"
	"when": "never"

	export function doesProfileSupportConnectionType(profile: IProfileLoaded, connectionType: string): boolean {
	export function doesProfileSupportConnectionType(profile: IProfileLoaded, connectionType: "JES" \| "USS"): boolean {

	const bundleDir = selectedBundle.getContainedResource().resource.attributes?.bundledir;
	const bundleDir = selectedBundle.getContainedResource()?.resource.attributes.bundledir;

	window.showErrorMessage(`Could not find bundle directory for ${selectedBundle.getLabel()
	window.showErrorMessage(`Could not find bundle directory for ${selectedBundle.getContainedResourceName()

show-bundle-in-uss-dir #473

Are you sure you want to change the base?

show-bundle-in-uss-dir #473

Uh oh!

Conversation

Khushboo-Sharma-110597 commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-commenter commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Khushboo-Sharma-110597 commented Oct 31, 2025

Uh oh!

davenice commented Oct 31, 2025

Uh oh!

Khushboo-Sharma-110597 commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

davenice commented Oct 31, 2025

Uh oh!

AndrewTwydell left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Khushboo-Sharma-110597 commented Oct 29, 2025 •

edited

Loading

codecov-commenter commented Oct 29, 2025 •

edited

Loading

Khushboo-Sharma-110597 commented Oct 31, 2025 •

edited

Loading