Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinispan doc updates #4101

Open
wants to merge 14 commits into
base: docs-staging
Choose a base branch
from

Conversation

pj892031
Copy link
Contributor

This PR contains two versions on new file api-mediation-infinispan.md.

The updates is to respect changes from these PRs:

The text in versioned_docs/version-v3.0.x/extend/extend-apiml/api-mediation-infinispan.md is valid for 3.0 and 3.1.
The text in docs/extend/extend-apiml/api-mediation-infinispan.md will be valid since 3.2.

Signed-off-by: Pavel Jareš <[email protected]>
Copy link

😺 Thank you for creating this PR! To publish your content to Zowe Docs, follow these required steps.

  • Add the label review: doc.
  • Identify your content topic with a label. (Examples: area: apiml, area: cli, area: install and config, etc.)
  • Specify the major Zowe release(s) for your content. (Examples: release: V1, release: V2, release: V3)
    • If adding content that needs to be removed from V3 documentation, add the V3 N/A tag.
  • Select the master branch if your PR updates content that is on the live site. Select docs-staging if your PR updates content for a future release.
  • Notify the Doc Squad about this PR. If you don't know whom should review your content, message the #zowe-doc Slack channel. If you know which Doc Squad writer should approve your content, add that person as a reviewer.

Need help? Contact the Doc Squad in the #zowe-doc Slack channel.

Copy link

github-actions bot commented Jan 30, 2025

@github-actions github-actions bot temporarily deployed to pull request January 30, 2025 08:47 Inactive
Signed-off-by: Pavel Jareš <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request January 30, 2025 12:34 Inactive
Signed-off-by: Andrew Jandacek <[email protected]>
Copy link
Collaborator

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending changes to Addressing Network Requirements

@github-actions github-actions bot temporarily deployed to pull request January 30, 2025 13:31 Inactive
@1000TurquoisePogs
Copy link
Member

@github-actions github-actions bot temporarily deployed to pull request February 4, 2025 07:58 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 6, 2025 09:58 Inactive
Signed-off-by: Andrew Jandacek <[email protected]>
@janan07 janan07 added area: apiml This issue is related to Zowe API Mediation Layer release: V3 Zowe V3 content review: doc Needs review by Doc Squad member review: sme Needs review by an SME labels Feb 6, 2025
@github-actions github-actions bot temporarily deployed to pull request February 6, 2025 10:58 Inactive
Signed-off-by: Andrew Jandacek <[email protected]>
Copy link
Collaborator

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending changes to Addressing Network Requirements per Sean's suggestion

@janan07 janan07 self-requested a review February 6, 2025 11:06
@github-actions github-actions bot temporarily deployed to pull request February 6, 2025 11:10 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 10, 2025 08:04 Inactive
@@ -68,19 +64,15 @@ Configure Infinispan as a storage solution through the Caching service by settin
caching-service:
storage:
mode: infinispan
infinispan:
infinispan:
jgroups.port: 7098
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand this works, but I think we usually just nest the properties

Suggested change
jgroups.port: 7098
groups:
port: 7098

Comment on lines 52 to 57
* **`zowe.components.caching-service.storage.infinispan.jgroups.host`**

(OPTIONAL)The default value is taken from zowe hostname. The hostname used by Infinispan to synchronise data among cahing-service instances.


* **`zowe.components.caching-service.storage.infinispan.keyExchange.port`**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no use case for infinispan running off-platform, right?


(OPTIONAL)The default value is `7098`. The port number used by Infinispan to synchronise data among cahing-service instances.
(Optional) The default value is `7600`. The port number is used by Infinispan to synchronise data among Caching Service instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is going with 3.2, I'd keep the 7098, I believe we need to update that in the defaults.yaml


(OPTIONAL)The default value is `7118`. The port number used by Infinispan to exchange encryption key among cahing-service instances.
(Optional) The default value is `7601`. The port number is used by Infinispan to exchange encryption key among Caching Service instances.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 87 to 88
infinispan:
jgroups.port: 7098
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing about being consistent, use the nested format

Comment on lines +91 to +92
dataLocation: /global/zowe/workspace/caching-service/data
indexLocation: /global/zowe/workspace/caching-service/index
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a comment to the example about needing to be in a non-shared filesystem (tendency to copy-paste)

Signed-off-by: Pavel Jareš <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request February 10, 2025 09:12 Inactive
@pj892031
Copy link
Contributor Author

Version 3.1 is changed by #4171

Comment on lines 43 to 44
| 7099 | zowe.components.caching-service.storage.infinispan.jgroups.keyExchange.port | The port at which the key server in Infinispan is listening. If the port is not available, the next port is probed, up to port+5. Used by the key server (server) to create an SSLServerSocket and by clients to connect to the key server.
| 7098 | zowe.components.caching-service.storage.infinispan.jgroups.port | Bind port for the socket that is used to form an Infinispan cluster.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be 7601 and 7600, right?

Signed-off-by: Pavel Jareš <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request February 10, 2025 15:25 Inactive
Signed-off-by: Andrew Jandacek <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request February 11, 2025 10:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request February 11, 2025 10:10 Inactive
Copy link
Collaborator

@janan07 janan07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and edited by doc squad

Signed-off-by: Pavel Jareš <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request February 13, 2025 11:52 Inactive
@pj892031 pj892031 requested a review from pablocarle February 14, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: apiml This issue is related to Zowe API Mediation Layer release: V3 Zowe V3 content review: doc Needs review by Doc Squad member review: sme Needs review by an SME
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants