Ability to disable bundled apps #346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement allows you to put the following in your YAML
If you did that prior, nothing much would happen. No errors, but no benefit.
Now, this is respected.
The logic is a bit silly:
So, 1) adds them blindly, and 3) removes them conditionally. Kind of silly but I did not want to cause any backward compatibility issues or update the "defaults" folder.
Defaults are unchanged. This just allows you to customize which plugins are available.
In this PR I also spotted a bug about manifest.json not being handled.
I have never seen a manifest.json. They have always been manifest.yaml
But during v2.0 development, we said it would be possible and so this code was written but untested I guess.