Update references to nodejs cluster functions #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
timgerstel
approved these changes
Oct 8, 2025
github-project-automation
bot
moved this from Ready for Review
to Merge Ready
in WebUI planning board
github-project-automation
bot
moved this from Merge Ready
to Closed
in WebUI planning board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as zowe/zlux-server-framework#619
https://nodejs.org/api/cluster.html#clusterismaster has been aliased to https://nodejs.org/api/cluster.html#clusterisprimary since node 16, and marked as deprecated by them.
In order to avoid surprises if the old name is removed in the future, I'm changing references in our code to point to the right objects today.
node 16 isn't even supported anymore, so all nodes in support have the new name.
I'm not 100% confident that extenders are not using this.isMaster in our code, so I'm leaving that there and creating an alias to this.isPrimary for the sake of organization, so mimic node's behavior.