Add nonce csp capability #316
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 1000TurquoisePogs <[email protected]>
lchudinov
reviewed
Jul 7, 2021
| } else if (preset == 'frame-strict') { | ||
| return `frame-src 'self' ${req.hostname};`; | ||
| } else if (preset == 'script-nonce') { | ||
| let nonce=crypto.randomBytes(16).toString('hex'); |
There was a problem hiding this comment.
I am wondering whether the approach with a random string would be suitable for HA mode when there are multiple app-servers running.
There was a problem hiding this comment.
Good point, probably not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for plugins to request use of a csp nonce and have their primary html be a template in which the nonce value is filled in when sent. This should allow plugins such as the desktop to be able to use a nonce in csp rules. Alternative CSP settings could be added in the future to use nonce in more situations.