Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dsclp): pass targetMember as start param for List.allMembers call #2415

Merged
merged 4 commits into from
Jan 22, 2025

Conversation

traeok
Copy link
Member

@traeok traeok commented Jan 17, 2025

What It Does

Fixes an issue spotted while working on #2409.

No changelog since the start param had no effect in List.allMembers before the work done in #2409.

How to Test

Review Checklist
I certify that I have:

Additional Comments

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.33%. Comparing base (0d752a5) to head (8c3dea4).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2415   +/-   ##
=======================================
  Coverage   91.33%   91.33%           
=======================================
  Files         639      639           
  Lines       18251    18251           
  Branches     3945     3946    +1     
=======================================
  Hits        16670    16670           
  Misses       1579     1579           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@traeok traeok marked this pull request as ready for review January 21, 2025 13:38
Copy link

📅 Suggested merge-by date: 2/4/2025

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for passing the right parm. 🙏
And I agree with you on the comment below 🙏

No changelog since the start param had no effect in List.allMembers before the work done in #2409.

LGTM! 😋

@traeok traeok merged commit b3feef9 into master Jan 22, 2025
23 checks passed
@traeok traeok deleted the fix/dsclp/start-param branch January 22, 2025 13:24
@traeok traeok added the release-current Indicates that there is no new functionality being delivered label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants