-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dsclp): pass targetMember
as start
param for List.allMembers
call
#2415
Conversation
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2415 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 639 639
Lines 18251 18251
Branches 3945 3946 +1
=======================================
Hits 16670 16670
Misses 1579 1579
Partials 2 2 ☔ View full report in Codecov by Sentry. |
📅 Suggested merge-by date: 2/4/2025 |
Signed-off-by: Trae Yelovich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for passing the right parm. 🙏
And I agree with you on the comment below 🙏
No changelog since the start param had no effect in List.allMembers before the work done in #2409.
LGTM! 😋
|
What It Does
Fixes an issue spotted while working on #2409.
No changelog since the
start
param had no effect inList.allMembers
before the work done in #2409.How to Test
Review Checklist
I certify that I have:
Additional Comments