refactor(zosfiles/List): maxLength with multiple patterns
#2417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trae Yelovich <[email protected]>
|
📅 Suggested merge-by date: 2/5/2025 |
traeok
changed the title
maxLength with multiple patterns
traeok
changed the title
maxLength with multiple patternsmaxLength with multiple patterns
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2417 +/- ##
=======================================
Coverage 91.33% 91.34%
=======================================
Files 639 639
Lines 18251 18258 +7
Branches 3836 3912 +76
=======================================
+ Hits 16670 16677 +7
Misses 1579 1579
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
traeok
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
pujal0909,
jace-roell and
ATorrise
gejohnston
approved these changes
Jan 23, 2025
ATorrise
approved these changes
Jan 28, 2025
Signed-off-by: Trae Yelovich <[email protected]>
traeok
force-pushed
the
fix/list-multiple-pats-maxlength
branch
from
53b8b37 to
8949068
Compare
zFernand0
approved these changes
Jan 28, 2025
|
jace-roell
approved these changes
Jan 28, 2025
|
Release succeeded for the The following packages have been published:
Powered by Octorelease 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
This PR improves the behavior of the
maxLengthparameter when listing multiple patterns. We'll gradually increment the total number of items returned for each pattern, and once we've reached the max length, we'll stop listing patterns.How to Test
Review Checklist
I certify that I have: