copy dsclp command resulting in spacu attribute always being TRACK #2419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jace-roell <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2419 +/- ##
=======================================
Coverage 91.34% 91.34%
=======================================
Files 639 639
Lines 18258 18259 +1
Branches 3912 3840 -72
=======================================
+ Hits 16677 16678 +1
Misses 1579 1579
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
|
📅 Suggested merge-by date: 2/10/2025 |
jace-roell
requested review from
t1m0thyj,
gejohnston,
zFernand0,
awharn,
pujal0909,
traeok,
anaxceron and
ATorrise
anaxceron
reviewed
Jan 28, 2025
anaxceron
approved these changes
Jan 28, 2025
traeok
approved these changes
Jan 28, 2025
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
|
zFernand0
previously requested changes
Jan 29, 2025
There was a problem hiding this comment.
Functionality LGTM! 😋
Left a few comments.
Also, I'm seeing the deferredPromise license headers being updated. 😋
Feel free to address it on just one PR 😋
But I believe @pujal0909 's PR already does 😋
Signed-off-by: jace-roell <[email protected]>
zFernand0
previously requested changes
Jan 29, 2025
Signed-off-by: jace-roell <[email protected]>
zFernand0
approved these changes
Jan 29, 2025
zFernand0
added
the
release-current
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What It Does
Fixed an issue in the Copy.dataSetCrossLPAR() function where the
spacuattribute of the copied data set was always set toTRK, regardless of the source data set's attributes.How to Test
Run
zowe files copy dsclp <sourceMember> <targetMember> --target-zosmf-p <profile>Where
<profile>is the name of the profile for a remote LPAR (can be the same LPAR as the one being tested against)<sourceMember>is a member of a data set where the dataset has aspacuattribute ofCYLINDERS(default)<targetMember>is the target location of the copied dataset/memberObserve that without the fix, the
spacuof the copied data set will always be "TRACKS"Observe that with the fix, the
spacuof the copied data set will reflect that of the source dataset.Review Checklist
I certify that I have: