- 
                Notifications
    You must be signed in to change notification settings 
- Fork 92
Don't delete existing file if download fails #2618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: JWaters02 <[email protected]>
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##           master    #2618      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         644      644              
  Lines       19143    19154      +11     
  Branches     4124     4241     +117     
==========================================
+ Hits        17577    17586       +9     
- Misses       1564     1566       +2     
  Partials        2        2              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| I don't understand what is wrong with this PR in the code analysis, the link opens in my PR but then opens issues that are really old | 
Signed-off-by: Trae Yelovich <[email protected]>
| 
 | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM, thanks Joshua



What It Does
Fixes #2595
How to Test
Run command to download a hekin chonker of a file (that takes a while to download) (successfully). Now run the command again but this time kill your network halfway through the download. See that the original file is no longer deleted.
Review Checklist
I certify that I have:
Additional Comments