Skip to content

Conversation

@JWaters02
Copy link
Member

What It Does

Fixes #2595

How to Test

Run command to download a hekin chonker of a file (that takes a while to download) (successfully). Now run the command again but this time kill your network halfway through the download. See that the original file is no longer deleted.

Review Checklist
I certify that I have:

  • updated the changelog
  • manually tested my changes
  • added/updated automated unit/integration tests
  • created/ran system tests (provide build number if applicable)
  • followed the contribution guidelines

Additional Comments

@github-project-automation github-project-automation bot moved this to New Issues in Zowe CLI Squad Oct 5, 2025
@zowe-robot zowe-robot moved this from New Issues to Review/QA in Zowe CLI Squad Oct 5, 2025
@JWaters02 JWaters02 changed the title Don't existing file if download fails Don't delete existing file if download fails Oct 5, 2025
@codecov
Copy link

codecov bot commented Oct 5, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.81%. Comparing base (fdd6221) to head (d42834b).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
packages/zosfiles/src/methods/download/Download.ts 85.71% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2618      +/-   ##
==========================================
- Coverage   91.81%   91.81%   -0.01%     
==========================================
  Files         644      644              
  Lines       19143    19154      +11     
  Branches     4124     4241     +117     
==========================================
+ Hits        17577    17586       +9     
- Misses       1564     1566       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JTonda JTonda requested review from awharn, t1m0thyj and traeok October 6, 2025 15:10
@JWaters02
Copy link
Member Author

I don't understand what is wrong with this PR in the code analysis, the link opens in my PR but then opens issues that are really old

@sonarqubecloud
Copy link

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, thanks Joshua

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Review/QA

Development

Successfully merging this pull request may close these issues.

If downloading data set fails and file already exists in the path, it is deleted

2 participants