Skip to content

Fix overwrite option not being used in data set and uss file downloads #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Fix overwrite option not being used in data set and uss file downloads #2620

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
116f787
fix: overwrite option not being used on data set download commands
JWaters02 Oct 5, 2025
a572b14
fix: let allMembers handle ow and resp for allDataSets for PDS
JWaters02 Oct 6, 2025
dbbb2e9
fix: ussFile respects overwrite option
JWaters02 Oct 6, 2025
34c9d31
tests: pass all existing tests
JWaters02 Oct 6, 2025
28b92cb
tests: write new cases for overwrite option
JWaters02 Oct 6, 2025
94669fe
chore: changelog
JWaters02 Oct 6, 2025
5176475
chore: warnings
JWaters02 Oct 6, 2025
4396ddd
chore: cli changelog
JWaters02 Oct 6, 2025
e803748
tests: update snapshot files
JWaters02 Oct 6, 2025
5e25539
tests: update int tests snapshots
JWaters02 Oct 16, 2025
2879aae
tests: fix tests
JWaters02 Oct 18, 2025
bc9289e
Merge branch 'master' into fix/download-overwrite
JWaters02 Oct 18, 2025
4784916
tests: try fix unix failing test
JWaters02 Oct 18, 2025
ea084ab
tests: maybe explicitly defining path imports will work?
JWaters02 Oct 18, 2025
46eb97d
test: Fix case for mac/linux path check
traeok Oct 22, 2025
e58412f
Merge branch 'master' into fix/download-overwrite
traeok Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/zosfiles/download/Download.options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ export const DownloadOptions: { [key: string]: ICommandOptionDefinition } = {
},

/**
* The include hidden option for download
* The overwrite option for downloads
*/
overwrite: {
name: "overwrite",
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/src/zosfiles/download/am/AllMembers.definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ export const AllMembersDefinition: ICommandDefinition = {
DownloadOptions.extension,
DownloadOptions.maxConcurrentRequests,
DownloadOptions.preserveOriginalLetterCase,
DownloadOptions.failFast
DownloadOptions.failFast,
DownloadOptions.overwrite
].sort((a, b) => a.name.localeCompare(b.name)),
examples: [
{
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/zosfiles/download/am/AllMembers.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ export default class AllMembersHandler extends ZosFilesBaseHandler {
maxConcurrentRequests: commandParameters.arguments.maxConcurrentRequests,
preserveOriginalLetterCase: commandParameters.arguments.preserveOriginalLetterCase,
failFast: commandParameters.arguments.failFast,
overwrite: commandParameters.arguments.overwrite,
task: status,
responseTimeout: commandParameters.arguments.responseTimeout
});
Expand Down
5 changes: 3 additions & 2 deletions packages/cli/src/zosfiles/download/amm/AllMembersMatching.definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,8 @@ export const AllMembersMatchingDefinition: ICommandDefinition = {
DownloadOptions.excludePattern,
DownloadOptions.maxConcurrentRequests,
DownloadOptions.preserveOriginalLetterCase,
DownloadOptions.failFast
DownloadOptions.failFast,
DownloadOptions.overwrite
].sort((a, b) => a.name.localeCompare(b.name)),
examples: [
{
Expand All @@ -66,4 +67,4 @@ export const AllMembersMatchingDefinition: ICommandDefinition = {
options: `"ibmuser.cntl" "test*,M*" --exclude-patterns "M2*" --directory output`
}
]
};
};
3 changes: 2 additions & 1 deletion packages/cli/src/zosfiles/download/amm/AllMembersMatching.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,10 @@ export default class AllMembersMatchingHandler extends ZosFilesBaseHandler {
maxConcurrentRequests: commandParameters.arguments.maxConcurrentRequests,
preserveOriginalLetterCase: commandParameters.arguments.preserveOriginalLetterCase,
failFast: commandParameters.arguments.failFast,
overwrite: commandParameters.arguments.overwrite,
task: status,
responseTimeout: commandParameters.arguments.responseTimeout,
memberPatternResponse: response.apiResponse,
});
}
}
}
3 changes: 2 additions & 1 deletion packages/cli/src/zosfiles/download/ds/Dataset.definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ export const DatasetDefinition: ICommandDefinition = {
DownloadOptions.binary,
DownloadOptions.record,
DownloadOptions.preserveOriginalLetterCase,
DownloadOptions.encoding
DownloadOptions.encoding,
DownloadOptions.overwrite
].sort((a, b) => a.name.localeCompare(b.name)),
examples: [
{
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/src/zosfiles/download/dsm/DataSetMatching.definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ export const DataSetMatchingDefinition: ICommandDefinition = {
DownloadOptions.extensionMap,
DownloadOptions.maxConcurrentRequests,
DownloadOptions.preserveOriginalLetterCase,
DownloadOptions.failFast
DownloadOptions.failFast,
DownloadOptions.overwrite
].sort((a, b) => a.name.localeCompare(b.name)),
examples: [
{
Expand Down
1 change: 1 addition & 0 deletions packages/cli/src/zosfiles/download/dsm/DataSetMatching.handler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ export default class DataSetMatchingHandler extends ZosFilesBaseHandler {
maxConcurrentRequests: commandParameters.arguments.maxConcurrentRequests,
preserveOriginalLetterCase: commandParameters.arguments.preserveOriginalLetterCase,
failFast: commandParameters.arguments.failFast,
overwrite: commandParameters.arguments.overwrite,
task: downloadStatus,
responseTimeout: commandParameters.arguments.responseTimeout
};
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/src/zosfiles/download/uss/UssFile.definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ export const UssFileDefinition: ICommandDefinition = {
DownloadOptions.attributes,
DownloadOptions.file,
DownloadOptions.binary,
DownloadOptions.encoding
DownloadOptions.encoding,
DownloadOptions.overwrite
].sort((a, b) => a.name.localeCompare(b.name)),
examples: [
{
Expand Down
Loading
Loading