Unable to open a Sequential DS after renaming a favourited Sequential DS #3453

SanthoshiBoyina1 · 2025-02-10T19:14:13Z

Proposed changes

Fixes #3345

Release Notes

Milestone:

Changelog:

Types of changes

Bug fix (non-breaking change which fixes an issue)
Enhancement (non-breaking change which adds or improves functionality)
Breaking change (a change that would cause existing functionality to not work as expected)
Documentation (Markdown, README updates)
Other (please specify above in "Proposed changes" section)

Checklist

General

I have read the CONTRIBUTOR GUIDANCE wiki
All PR dependencies have been merged and published (if applicable)
A GIF or screenshot is included in the PR for visual changes
The pre-publish command has been executed:
- v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
- v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

There is coverage for the code that I have added
I have added new test cases and they are passing
I have manually tested the changes

Deployment

I have added developer documentation (if applicable)
Documentation should be added to Zowe Docs
- If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
- Otherwise, please check with the rest of the squad about any needed documentation before merging.
These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Santhoshi Boyina <[email protected]>

…ming the favorited pds Signed-off-by: Santhoshi Boyina <[email protected]>

…renaming a seq ds in the favorites Signed-off-by: Santhoshi Boyina <[email protected]>

Signed-off-by: Santhoshi Boyina <[email protected]>

…ee view upon renaming the seq ds from the ds tree view Signed-off-by: Santhoshi Boyina <[email protected]>

github-actions · 2025-02-10T19:14:30Z

📅 Suggested merge-by date: 2/24/2025

Signed-off-by: Santhoshi Boyina <[email protected]>

codecov · 2025-02-11T12:27:13Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.49%. Comparing base (8944fe3) to head (f395734).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3453      +/-   ##
==========================================
+ Coverage   93.44%   93.49%   +0.04%     
==========================================
  Files         120      120              
  Lines       12676    12694      +18     
  Branches     2884     2887       +3     
==========================================
+ Hits        11845    11868      +23     
+ Misses        830      825       -5     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Santhoshi Boyina <[email protected]>

packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetTree.unit.test.ts

Signed-off-by: Santhoshi Boyina <[email protected]>

laration in IZoweTree interface Signed-off-by: Santhoshi Boyina <[email protected]>

Signed-off-by: Santhoshi Boyina <[email protected]>

…the ds tree view Signed-off-by: Santhoshi Boyina <[email protected]>

Signed-off-by: Santhoshi Boyina <[email protected]>

JillieBeanSim

LGTM! thanks for the fix @SanthoshiBoyina1

traeok

This fix LGTM, thanks Santhoshi! I had a quick question before approving, but the changes make sense to me.

packages/zowe-explorer/src/configuration/Definitions.ts

t1m0thyj

Looks pretty good, thanks @SanthoshiBoyina1! Just one question

t1m0thyj · 2025-02-18T15:20:01Z

packages/zowe-explorer/src/configuration/Definitions.ts

@@ -67,6 +67,7 @@ export namespace Definitions {
        session?: imperative.Session;
        profile?: imperative.IProfileLoaded;
        contextOverride?: string;
+        contextValue?: string;


Do we need to add contextValue here? It feels redundant since it's already defined on tree nodes, and the IZoweTreeOpts type (which is only used in constructors) has contextOverride to support overriding the default context value.

Signed-off-by: Santhoshi Boyina <[email protected]>

JillieBeanSim

LGTM! thanks @SanthoshiBoyina1 for the fix

zFernand0

LGTM! 😋

great catch on this edge case 🤯
Thanks for the fix! 🙏

SanthoshiBoyina1 added 5 commits February 10, 2025 19:45

To include additional parameter in the renameNode function

333c57b

Signed-off-by: Santhoshi Boyina <[email protected]>

To fix error with opening a dataset member from the ds tree upon rena…

0e34233

…ming the favorited pds Signed-off-by: Santhoshi Boyina <[email protected]>

fix: to fix error seen with opening a seq ds from ds tree view after …

0612743

…renaming a seq ds in the favorites Signed-off-by: Santhoshi Boyina <[email protected]>

To add additional attribute newUri for the renameFavorite function

7d073e9

Signed-off-by: Santhoshi Boyina <[email protected]>

fix: to fix error seen with opening a sequential ds from favorites tr…

f6269af

…ee view upon renaming the seq ds from the ds tree view Signed-off-by: Santhoshi Boyina <[email protected]>

SanthoshiBoyina1 requested review from t1m0thyj, zFernand0, JillieBeanSim, traeok, anaxceron, adam-wolfe and likhithanimma1 February 10, 2025 19:14

SanthoshiBoyina1 self-assigned this Feb 10, 2025

pull-request-size bot added the size/M label Feb 10, 2025

SanthoshiBoyina1 added the no-changelog Add to PR's that don't require a CHANGELOG update label Feb 10, 2025

anaxceron previously approved these changes Feb 10, 2025

View reviewed changes

SanthoshiBoyina1 added 2 commits February 11, 2025 17:51

To add contextValue property in the IZoweTreeOpts interface

8f66e11

Signed-off-by: Santhoshi Boyina <[email protected]>

fix: To fix failing test cases

6deae9b

Signed-off-by: Santhoshi Boyina <[email protected]>

SanthoshiBoyina1 dismissed anaxceron’s stale review via 6deae9b February 11, 2025 12:24

SanthoshiBoyina1 and others added 2 commits February 11, 2025 19:38

Merge branch 'main' into fix/renameSeqDs

65a8ec2

to add unit test coverage for rename of seq ds

58cc393

Signed-off-by: Santhoshi Boyina <[email protected]>

pull-request-size bot added size/L and removed size/M labels Feb 11, 2025

SanthoshiBoyina1 added 2 commits February 11, 2025 22:30

To improve unit test coverage for rename of favorited seq ds

ed4e2c7

Signed-off-by: Santhoshi Boyina <[email protected]>

to add unit test case for opening a pds after renaming a favorited pds

1c5aacd

Signed-off-by: Santhoshi Boyina <[email protected]>

github-advanced-security bot found potential problems Feb 11, 2025

View reviewed changes

packages/zowe-explorer/__tests__/__unit__/trees/dataset/DatasetTree.unit.test.ts Fixed Show fixed Hide fixed

To make minor modifications for the renameNode Function

763834f

Signed-off-by: Santhoshi Boyina <[email protected]>

SanthoshiBoyina1 requested a review from anaxceron February 11, 2025 18:04

SanthoshiBoyina1 and others added 8 commits February 14, 2025 12:39

To revert back to renameNode de

381c619

laration in IZoweTree interface Signed-off-by: Santhoshi Boyina <[email protected]>

To modify renameNode parameter in a unit test case

db6b033

Signed-off-by: Santhoshi Boyina <[email protected]>

To fix unable to open pds member from favorite after renaming pds in …

812885b

…the ds tree view Signed-off-by: Santhoshi Boyina <[email protected]>

To add unit test case to rename a favorited PDS

0327aba

Signed-off-by: Santhoshi Boyina <[email protected]>

Merge branch 'main' into fix/renameSeqDs

13e262e

To add back afterLabel parameter in the renameNode

63732e5

Signed-off-by: Santhoshi Boyina <[email protected]>

To add afterEach() in the rename function test suite

32d42d6

Signed-off-by: Santhoshi Boyina <[email protected]>

To add unit test case to check rename of favorite pds

e14ec33

Signed-off-by: Santhoshi Boyina <[email protected]>

SanthoshiBoyina1 requested a review from traeok February 14, 2025 20:21

JillieBeanSim previously approved these changes Feb 18, 2025

View reviewed changes

Merge branch 'main' into fix/renameSeqDs

f8f8039

traeok reviewed Feb 18, 2025

View reviewed changes

packages/zowe-explorer/src/configuration/Definitions.ts Outdated Show resolved Hide resolved

t1m0thyj reviewed Feb 18, 2025

View reviewed changes

anaxceron previously approved these changes Feb 18, 2025

View reviewed changes

SanthoshiBoyina1 and others added 2 commits February 18, 2025 21:25

Merge branch 'main' into fix/renameSeqDs

f57f5d8

To revert contextOverride property

194fcf0

Signed-off-by: Santhoshi Boyina <[email protected]>

SanthoshiBoyina1 dismissed stale reviews from JillieBeanSim and anaxceron via 194fcf0 February 18, 2025 16:48

SanthoshiBoyina1 requested review from t1m0thyj, traeok, JillieBeanSim and anaxceron February 18, 2025 16:51

anaxceron approved these changes Feb 18, 2025

View reviewed changes

traeok approved these changes Feb 18, 2025

View reviewed changes

JillieBeanSim added 2 commits February 18, 2025 16:12

Merge branch 'main' into fix/renameSeqDs

a6db56b

Merge branch 'main' into fix/renameSeqDs

f395734

JillieBeanSim approved these changes Feb 19, 2025

View reviewed changes

JillieBeanSim merged commit 5c645bc into main Feb 19, 2025
23 checks passed

JillieBeanSim deleted the fix/renameSeqDs branch February 19, 2025 15:53

zFernand0 approved these changes Feb 19, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Unable to open a Sequential DS after renaming a favourited Sequential DS #3453

Unable to open a Sequential DS after renaming a favourited Sequential DS #3453

SanthoshiBoyina1 commented Feb 10, 2025

github-actions bot commented Feb 10, 2025

codecov bot commented Feb 11, 2025 •

edited

Loading

JillieBeanSim left a comment

traeok left a comment

t1m0thyj left a comment •

edited

Loading

t1m0thyj Feb 18, 2025

JillieBeanSim left a comment

zFernand0 left a comment

Unable to open a Sequential DS after renaming a favourited Sequential DS #3453

Unable to open a Sequential DS after renaming a favourited Sequential DS #3453

Conversation

SanthoshiBoyina1 commented Feb 10, 2025

Proposed changes

Release Notes

Types of changes

Checklist

Further comments

github-actions bot commented Feb 10, 2025

codecov bot commented Feb 11, 2025 • edited Loading

Codecov Report

JillieBeanSim left a comment

Choose a reason for hiding this comment

traeok left a comment

Choose a reason for hiding this comment

t1m0thyj left a comment • edited Loading

Choose a reason for hiding this comment

t1m0thyj Feb 18, 2025

Choose a reason for hiding this comment

JillieBeanSim left a comment

Choose a reason for hiding this comment

zFernand0 left a comment

Choose a reason for hiding this comment

LGTM! 😋

codecov bot commented Feb 11, 2025 •

edited

Loading

t1m0thyj left a comment •

edited

Loading