Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UNIX attributes refresh button #3462

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Conversation

JillieBeanSim
Copy link
Contributor

@JillieBeanSim JillieBeanSim commented Feb 17, 2025

Proposed changes

Fixes #3238

1 thing I haven't figured out is the Apply Changes button active when changes come from host because the local & fetched are different even with passing allowUpdate: false

Release Notes

Milestone: 3.1.2 ? (does introduce new IZoweUSSTreeNode.fetchAttributes so may be 3.2.0)

Changelog:

  • ZE - Fixed an issue with UNIX file edit attributes refresh button not updating/reverting values correctly. #3238
  • ZE API - Added new fetchAttributes API to IZoweUSSTreeNode to fetch latest attributes for UNIX files. #3238

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

@JillieBeanSim JillieBeanSim self-assigned this Feb 17, 2025
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.52%. Comparing base (5c645bc) to head (71e746e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3462      +/-   ##
==========================================
+ Coverage   93.49%   93.52%   +0.02%     
==========================================
  Files         120      120              
  Lines       12694    12705      +11     
  Branches     2934     2816     -118     
==========================================
+ Hits        11868    11882      +14     
+ Misses        825      822       -3     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim added this to the v3.1.2 milestone Feb 17, 2025
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim marked this pull request as ready for review February 18, 2025 13:46
Copy link

📅 Suggested merge-by date: 3/4/2025

Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this Billie! I have a couple requests, but the fix works well for me 👍

@pull-request-size pull-request-size bot added size/L and removed size/M labels Feb 18, 2025
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
@JillieBeanSim JillieBeanSim requested a review from traeok February 18, 2025 22:08
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Billie for quickly addressing my feedback - I spotted one more item that needs changed but the functionality looks good to me.

@@ -352,6 +352,8 @@ export interface IZoweUSSTreeNode extends IZoweTreeNode {
*/
getAttributes(): Types.FileAttributes | PromiseLike<Types.FileAttributes>;

fetchAttributes(): Types.FileAttributes | PromiseLike<Types.FileAttributes>;
Copy link
Member

@traeok traeok Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch this during the last round of review, but if we need to define a new function on this interface, it has to be marked optional to avoid breaking changes (for any extender that implements this interface)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @traeok good catch! addressed in latest commit

@JillieBeanSim JillieBeanSim requested a review from traeok February 19, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review/QA
Development

Successfully merging this pull request may close these issues.

Edit attributes refresh not updating values
2 participants