-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix UNIX attributes refresh button #3462
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3462 +/- ##
==========================================
+ Coverage 93.49% 93.52% +0.02%
==========================================
Files 120 120
Lines 12694 12705 +11
Branches 2934 2816 -118
==========================================
+ Hits 11868 11882 +14
+ Misses 825 822 -3
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
📅 Suggested merge-by date: 3/4/2025 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this Billie! I have a couple requests, but the fix works well for me 👍
packages/zowe-explorer/__tests__/__unit__/trees/uss/ZoweUSSNode.unit.test.ts
Fixed
Show fixed
Hide fixed
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Billie for quickly addressing my feedback - I spotted one more item that needs changed but the functionality looks good to me.
@@ -352,6 +352,8 @@ export interface IZoweUSSTreeNode extends IZoweTreeNode { | |||
*/ | |||
getAttributes(): Types.FileAttributes | PromiseLike<Types.FileAttributes>; | |||
|
|||
fetchAttributes(): Types.FileAttributes | PromiseLike<Types.FileAttributes>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I didn't catch this during the last round of review, but if we need to define a new function on this interface, it has to be marked optional to avoid breaking changes (for any extender that implements this interface)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @traeok good catch! addressed in latest commit
Signed-off-by: Billie Simmons <[email protected]>
Proposed changes
Fixes #3238
1 thing I haven't figured out is the Apply Changes button active when changes come from host because the local & fetched are different even with passing allowUpdate: false
Release Notes
Milestone: 3.1.2 ? (does introduce new
IZoweUSSTreeNode.fetchAttributes
so may be 3.2.0)Changelog:
fetchAttributes
API toIZoweUSSTreeNode
to fetch latest attributes for UNIX files. #3238Types of changes
Checklist
General
yarn workspace vscode-extension-for-zowe vscode:prepublish
pnpm --filter vscode-extension-for-zowe vscode:prepublish
Code coverage
Deployment
Further comments