Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port #3448 to release/3.1 #3469

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Port #3448 to release/3.1 #3469

merged 1 commit into from
Feb 19, 2025

Conversation

JWaters02
Copy link
Member

Proposed changes

Ports #3448 to the release/3.1 branch in preparation for the 3.1.2 patch release.

Release Notes

Milestone: 3.1.2

Changelog: Fixed issue where deleting too many nodes at once would cause the confirmation prompt to be oversized.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

…mation prompt to be oversized (zowe#3448)

* Fix zowe#3254

Signed-off-by: JWaters02 <[email protected]>

* Fix oversized prompt for deleting USS files

Signed-off-by: JWaters02 <[email protected]>

* Fix oversized prompt for deleting datasets

Signed-off-by: JWaters02 <[email protected]>

Update changelog entry to be more generic

Signed-off-by: JWaters02 <[email protected]>

* Fix duplicate changelog entries

Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: JWaters02 <[email protected]>
Signed-off-by: Joshua Waters <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Co-authored-by: Billie Simmons <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
@JWaters02 JWaters02 self-assigned this Feb 18, 2025
@JWaters02 JWaters02 added this to the v3.1.2 milestone Feb 18, 2025
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.22%. Comparing base (94e87a5) to head (96c7402).
Report is 1 commits behind head on release/3.1.

Additional details and impacted files
@@              Coverage Diff              @@
##           release/3.1    #3469    +/-   ##
=============================================
  Coverage        93.21%   93.22%            
=============================================
  Files              120      120            
  Lines            12524    12541    +17     
  Branches          2772     2897   +125     
=============================================
+ Hits             11674    11691    +17     
  Misses             849      849            
  Partials             1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JillieBeanSim JillieBeanSim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for porting the fix @JWaters02

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Thanks for porting over 🙏

@zFernand0 zFernand0 merged commit a16ae9d into zowe:release/3.1 Feb 19, 2025
19 of 20 checks passed
@JWaters02 JWaters02 deleted the port-3448 branch February 20, 2025 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants