Skip to content

Conversation

@jace-roell
Copy link
Contributor

@jace-roell jace-roell commented Aug 27, 2025

Proposed changes

FileSystem calls allow users to correct invalid credentials and continue with the function call.

  1. This enables a retry functionality for FileSystem calls and will reprompt users indefinitely until a prompt is cancelled or valid credentials are entered.
  2. Extension activation will no longer await virtual workspace fetching
  3. Fixes race conditions with authentication for parallel FS calls.
    - FS calls will run in sequence until valid authentication is provided, then FS calls for that profile will be released to run in parallel
  4. Fixes duplicate prompting on SSO login/logout when multiple virtual workspaces are open.

Steps to Test:

  1. Install the .vsix linked to this PR

  2. Clone the vscode-extension-samples repo

  3. cd into helloworld-sample

  4. Navigate to helloworld-sample/src/extension.ts

  5. Place this sample script into extension.ts

import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	// Place an existing profile name with invalid credentials (recommended invalid user to avoid lockout)
	const profile = 'zosmf';
	async function testDS(): Promise<void> {
                 // Ensure is PDS
		const dsn = 'ZOWEUSER.TEST.FILE';

		try {
			const statResult = await vscode.workspace.fs.stat(
				vscode.Uri.parse(`zowe-ds:/${profile}/${dsn}?fetch=true`)
			);
			console.info(`stat success ${JSON.stringify(statResult)}`);
		} catch (err) {
			console.error(`stat error ${JSON.stringify(err)}`);
		}

		try {
			const readResult = await vscode.workspace.fs.readDirectory(
				vscode.Uri.parse(`zowe-ds:/${profile}/${dsn}`)
			);
			console.info(`read success ${JSON.stringify(readResult)}`);
		} catch (err) {
			console.error(`read error ${JSON.stringify(err)}`);
		}
	}
	async function testUSS(): Promise<void> {
		const ussFile = 'u/users/zoweuser/testDir';

		try {
			const statResult = await vscode.workspace.fs.stat(
				vscode.Uri.parse(`zowe-uss:/${profile}/${ussFile}?fetch=true`)
			);
			console.info(`stat success ${JSON.stringify(statResult)}`);
		} catch (err) {
			console.error(`stat error ${JSON.stringify(err)}`);
		}

		try {
			const readResult = await vscode.workspace.fs.readDirectory(
				vscode.Uri.parse(`zowe-uss:/${profile}/${ussFile}`)
			);
			console.info(`read success ${JSON.stringify(readResult)}`);
		} catch (err) {
			console.error(`read error ${JSON.stringify(err)}`);
		}
	}

	async function testJobs(): Promise<void> {
		const joburi = 'TSU01234';
		try {
			const statResult = await vscode.workspace.fs.stat(
				vscode.Uri.parse(`zowe-jobs:/${profile}/${joburi}`)
			);
			console.info(`stat success ${JSON.stringify(statResult)}`);
		} catch (err) {
			console.error(`stat error ${JSON.stringify(err)}`);
		}

		try {
			const readResult = await vscode.workspace.fs.readDirectory(
				vscode.Uri.parse(`zowe-jobs:/${profile}/${joburi}`)
			);
			console.info(`read success ${JSON.stringify(readResult)}`);
		} catch (err) {
			console.error(`read error ${JSON.stringify(err)}`);
		}
	}
	// Register the command
	const disposable = vscode.commands.registerCommand('extension.helloWorld', async () => {
		await testDS();
		// await testUSS();

		// Jobs does not support remote lookup
		// await testJobs();
	});

	context.subscriptions.push(disposable);
}

// this method is called when your extension is deactivated
export function deactivate() {}

ensure the proper modifications are made in the script for uri and target profile

  1. Run npm install
  • Ensure the profile in the test script has invalid credentials
  1. Run Extension Development Host
    Test Scenarios
    1. Reprompt Loop
      a. Run the "Hello World" command palette command
      b. If invalid credentials are entered, new prompts will appear indefinitely. You can escape this loop at any point by cancelling the request
    2. Valid credentials
      a. Run the "Hello World" command palette command
      b. If valid credentials are entered, the command that invoked the prompt will be properly retried and succeed.
      The previous behavior is that the initial request would fail but the subsequent would pass
    3. Virtual workspaces [Block file system requests until extensions are activated #3880]
      a. Open multiple virtual workspace entries.
      b. Reload vscode
      c. The extension activation will no longer await fetching the virtual workspaces
      Note: virtual workspace fetching now runs in parallel

Resolves #3864

  1. Add multiple data sets (ideally 10+) to your virtual workspace via a profile using API ML
  2. Log out of SSO and reload vscode
  3. Log in via SSO and a duplicate SSO login prompt would transiently appear

Resolves #3858

  1. Add multiple data sets (ideally 10+) to your virtual workspace via a profile using API ML
  2. Log out of SSO and reload vscode
  3. Login then Logout of SSO, it should prompt to update credentials in an infinite loop.

Both scenarios should remove the duplicate authentication prompts

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have tested new functionality with the FTP extension and profile verifying no extender profile type breakages introduced
  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
@github-actions
Copy link

github-actions bot commented Aug 27, 2025

zowe-explorer-vsix Download
Build Details
Name Information
PR Commit 425f14f
Merge Commit f5371d3
Size 3.7 MB
Last Updated By jace-roell
Last Updated Oct 21, 25, 5:42:49 PM UTC
Expires At Jan 19, 26, 5:41:02 PM UTC

@adam-wolfe adam-wolfe linked an issue Aug 27, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 91.37380% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.04%. Comparing base (22c38d5) to head (d5ed520).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...we-explorer/src/trees/dataset/DatasetFSProvider.ts 88.76% 10 Missing ⚠️
...kages/zowe-explorer/src/trees/uss/UssFSProvider.ts 93.05% 5 Missing ⚠️
...ages/zowe-explorer-api/src/profiles/AuthHandler.ts 94.93% 4 Missing ⚠️
packages/zowe-explorer/src/utils/AuthUtils.ts 91.42% 3 Missing ⚠️
...ckages/zowe-explorer/src/configuration/Profiles.ts 60.00% 2 Missing ⚠️
.../zowe-explorer/src/management/ProfileManagement.ts 60.00% 2 Missing ⚠️
...kages/zowe-explorer/src/trees/shared/SharedInit.ts 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3830    +/-   ##
========================================
  Coverage   94.04%   94.04%            
========================================
  Files         129      129            
  Lines       15472    15589   +117     
  Branches     3721     3562   -159     
========================================
+ Hits        14550    14661   +111     
- Misses        920      926     +6     
  Partials        2        2            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: jace-roell <[email protected]>
@jace-roell jace-roell marked this pull request as ready for review September 2, 2025 17:13
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

📅 Suggested merge-by date: 11/3/2025

@adam-wolfe

This comment was marked as resolved.

@jace-roell jace-roell linked an issue Oct 17, 2025 that may be closed by this pull request
@jace-roell jace-roell marked this pull request as ready for review October 20, 2025 13:33
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code Oct 20, 2025
Signed-off-by: jace-roell <[email protected]>
Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😋

Thanks for implementing retries 🙏

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment re: minor edit


### Bug fixes

- Fixed an issue where the `promptForAuthentication` function would throw a `AuthCanceledError` on invalid authentication for SSO login. [#3830](https://github.com/zowe/zowe-explorer-vscode/pull/3830)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is my review comment

Signed-off-by: jace-roell <[email protected]>
@zFernand0 zFernand0 merged commit 4331cf4 into main Oct 21, 2025
13 checks passed
@zFernand0 zFernand0 deleted the extender-retry branch October 21, 2025 18:08
@github-project-automation github-project-automation bot moved this from Review/QA to Closed in Zowe Explorer for VS Code Oct 21, 2025
jace-roell added a commit that referenced this pull request Oct 21, 2025
* init

Signed-off-by: jace-roell <[email protected]>

* setting configuration

Signed-off-by: jace-roell <[email protected]>

* refactor retry

Signed-off-by: jace-roell <[email protected]>

* test updates

Signed-off-by: jace-roell <[email protected]>

* fix dataset provider function buff builder location

Signed-off-by: jace-roell <[email protected]>

* ds text fix

Signed-off-by: jace-roell <[email protected]>

* remove ds handleAuthCall

Signed-off-by: jace-roell <[email protected]>

* fix fs tests

Signed-off-by: jace-roell <[email protected]>

* usstree fix

Signed-off-by: jace-roell <[email protected]>

* fix zoom test

Signed-off-by: jace-roell <[email protected]>

* auth handler init test

Signed-off-by: jace-roell <[email protected]>

* test

Signed-off-by: jace-roell <[email protected]>

* update main

Signed-off-by: jace-roell <[email protected]>

* patch coverage

Signed-off-by: jace-roell <[email protected]>

* changelog

Signed-off-by: jace-roell <[email protected]>

* test fix and unused map

Signed-off-by: jace-roell <[email protected]>

* fix broken mock

Signed-off-by: jace-roell <[email protected]>

* fix

Signed-off-by: jace-roell <[email protected]>

* remove only

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* move maxExtenderRetry to a setting instead of under table

Signed-off-by: jace-roell <[email protected]>

* track prompts by profile

Signed-off-by: jace-roell <[email protected]>

* rework to handle no profile object on profile uri

Signed-off-by: jace-roell <[email protected]>

* remove log statement

Signed-off-by: jace-roell <[email protected]>

* fix token check

Signed-off-by: jace-roell <[email protected]>

* init

Signed-off-by: jace-roell <[email protected]>

* fix inital auth prompt

Signed-off-by: jace-roell <[email protected]>

* test

Signed-off-by: jace-roell <[email protected]>

* fix void for init workspace

Signed-off-by: jace-roell <[email protected]>

* implement comment fixes, search after sso login

Signed-off-by: jace-roell <[email protected]>

* sso login after search dataset filter

Signed-off-by: jace-roell <[email protected]>

* shared init test fix

Signed-off-by: jace-roell <[email protected]>

* check before changing node collapisbleState

Signed-off-by: jace-roell <[email protected]>

* existing test fixes

Signed-off-by: jace-roell <[email protected]>

* patch cov

Signed-off-by: jace-roell <[email protected]>

* log statement

Signed-off-by: jace-roell <[email protected]>

* remove auth type none check

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* duplicate prompt

Signed-off-by: jace-roell <[email protected]>

* changelog

Signed-off-by: jace-roell <[email protected]>

* direct FS calls check profile type for auth prompt

Signed-off-by: jace-roell <[email protected]>

* remove timeout by default

Signed-off-by: jace-roell <[email protected]>

* address feedback

Signed-off-by: jace-roell <[email protected]>

* update setting name to Max Request Retry

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* awaitTimeout removal for some UssFs calls, retry wait, handleAuthError dont wait

Signed-off-by: jace-roell <[email protected]>

* test fixes

Signed-off-by: jace-roell <[email protected]>

* test commit

Signed-off-by: jace-roell <[email protected]>

* refactor: Wait for active request to resolve auth prompt

Signed-off-by: Trae Yelovich <[email protected]>

* update prompting behavior in FS to adhere to prompt description

Signed-off-by: Trae Yelovich <[email protected]>

* fix: remove extra lockProfile call in retry logic

Signed-off-by: Trae Yelovich <[email protected]>

* respect retry count

Signed-off-by: jace-roell <[email protected]>

* change timeout to 30s

Signed-off-by: jace-roell <[email protected]>

* wip(refactor): Queue FS requests until one succeeds for a profile

Signed-off-by: Trae Yelovich <[email protected]>

* fix: finish activating before fetching workspaces

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: skip .vscode calls in data set FS

Signed-off-by: Trae Yelovich <[email protected]>

* fix failing tests

Signed-off-by: jace-roell <[email protected]>

* add tests & typedoc for sequential/parallel handling

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add preceding slash to .vscode check in DS FS

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: release queued reqs after parallel mode re-enabled

Signed-off-by: Trae Yelovich <[email protected]>

* address lint errors

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: waitForUnlock no longer times out >30s

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Jace Roell <[email protected]>

* wip: remove request retry setting

Signed-off-by: jace-roell <[email protected]>

* remove try catch on canceled prompt

Signed-off-by: jace-roell <[email protected]>

* remove check for state of authentication - only consider cancellation

Signed-off-by: jace-roell <[email protected]>

* fix merge conflict and unused import

Signed-off-by: jace-roell <[email protected]>

* remove duplication in runSequentialIfEnabled catch block

Signed-off-by: Trae Yelovich <[email protected]>

* fix workspace extra prmopts

Signed-off-by: jace-roell <[email protected]>

* changelog update

Signed-off-by: jace-roell <[email protected]>

* fix changelog

Signed-off-by: jace-roell <[email protected]>

---------

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: Jace Roell <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: jace-roell <[email protected]>
JillieBeanSim added a commit that referenced this pull request Oct 24, 2025
* dev: Update pnpm from v8 to v10 (#3834)

* dev: Update pnpm from v8 to v10

Signed-off-by: Timothy Johnson <[email protected]>

* Fix deprecated Node and Preact types

Signed-off-by: Timothy Johnson <[email protected]>

* Require pnpm@10 in package.json

Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>

* Fix issues seen with convert v1 profiles prompt (#3846)

* fix create option for convert profiles

Signed-off-by: Billie Simmons <[email protected]>

* fix migrate prof option

Signed-off-by: Billie Simmons <[email protected]>

* fix broken tests

Signed-off-by: Billie Simmons <[email protected]>

* add changelog entry

Signed-off-by: Billie Simmons <[email protected]>

* run prepublish

Signed-off-by: Billie Simmons <[email protected]>

* fix no config dialog pop up after being presented with v1 profile options

Signed-off-by: Billie Simmons <[email protected]>

* fix changelog entry location

Signed-off-by: Billie Simmons <[email protected]>

---------

Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>

* Update dev deps for technical currency (#3872)

* Update dev deps for technical currency

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

* Remove dependency on Internet connection for ZE build

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

* Update packageManager field

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

* Fix version mismatch in pnpm lockfile

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>

* run prepublish

Signed-off-by: Billie Simmons <[email protected]>

* Update `tar-fs` transitive dependency for audit. (#3878)

Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>

* Fix error when deleting PDS members (#3875)

* Fix error when deleting PDS members

Signed-off-by: Timothy Johnson <[email protected]>

* Update unit tests

Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Co-authored-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>

* fix: include member attributes in Show Attributes view (#3881)

* fix: include member attrs. in Show Attributes view

Signed-off-by: Trae Yelovich <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* check for job spool correctly (#3870)

* check for job spool correctly

Signed-off-by: Dave Nice <[email protected]>

* refactor and create unit test

Signed-off-by: Dave Nice <[email protected]>

* unused import

Signed-off-by: Dave Nice <[email protected]>

* review comment

Signed-off-by: Dave Nice <[email protected]>

---------

Signed-off-by: Dave Nice <[email protected]>
Co-authored-by: Joshua Waters <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>

* port #3855

Signed-off-by: jace-roell <[email protected]>

* fix: update SDKs to fix CRLF handling for `putContents` on Windows  (#3890)

* chore: update Zowe SDKs

Signed-off-by: Trae Yelovich <[email protected]>

* update lock

Signed-off-by: Billie Simmons <[email protected]>

* chore: update changelogs

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* update lock

Signed-off-by: Billie Simmons <[email protected]>

* fix(uss): Throw error if `readFile` fails rather than returning empty contents  (#3895)

* fix: fetchFileAtUri in USS provider should return entry

Signed-off-by: Trae Yelovich <[email protected]>

* chore: changelogs

Signed-off-by: Trae Yelovich <[email protected]>

* Update packages/zowe-explorer-api/CHANGELOG.md

Co-authored-by: anaxceron <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: anaxceron <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* fix(ds): Prevent deleting members for the wrong profile (#3882)

* Fix members being deleted for the wrong profile

Signed-off-by: Timothy Johnson <[email protected]>

* Update changelog and fix tests

Signed-off-by: Timothy Johnson <[email protected]>

* Add unit test and simplify logic for selected nodes

Signed-off-by: Timothy Johnson <[email protected]>

* Restore line in changelog

Signed-off-by: Timothy Johnson <[email protected]>

* Fix lint error for unused import

Signed-off-by: Timothy Johnson <[email protected]>

* Fix createMember action listing data set twice

Signed-off-by: Timothy Johnson <[email protected]>

* Fix duplicates in getCount api

Signed-off-by: Timothy Johnson <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Co-authored-by: Jace Roell <[email protected]>

* Update FTP extension name in log messages (#3900)

Signed-off-by: Timothy Johnson <[email protected]>

* Update imperative settings when switching to custom credential manager   (#3860)

* Imperative.json file update for custom credentials

Signed-off-by: likhithanimma1 <[email protected]>

* Update packages/zowe-explorer/src/utils/ProfilesUtils.ts

Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>

* Add changelog entry

Signed-off-by: likhithanimma1 <[email protected]>

* Add unit test coverage

Signed-off-by: likhithanimma1 <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: anaxceron <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>

* Remove commented unit tests

Signed-off-by: likhithanimma1 <[email protected]>

---------

Signed-off-by: likhithanimma1 <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: anaxceron <[email protected]>

* Update z/OS Files SDK to fix DS cross-LPAR copy issue (#3896)

* chore: update z/OS Files SDK to 8.27.3

Signed-off-by: Trae Yelovich <[email protected]>

* update lock

Signed-off-by: Billie Simmons <[email protected]>

* chore: update changelog

Signed-off-by: Trae Yelovich <[email protected]>

---------

Signed-off-by: Trae Yelovich <[email protected]>

* Extender retry (#3830)

* init

Signed-off-by: jace-roell <[email protected]>

* setting configuration

Signed-off-by: jace-roell <[email protected]>

* refactor retry

Signed-off-by: jace-roell <[email protected]>

* test updates

Signed-off-by: jace-roell <[email protected]>

* fix dataset provider function buff builder location

Signed-off-by: jace-roell <[email protected]>

* ds text fix

Signed-off-by: jace-roell <[email protected]>

* remove ds handleAuthCall

Signed-off-by: jace-roell <[email protected]>

* fix fs tests

Signed-off-by: jace-roell <[email protected]>

* usstree fix

Signed-off-by: jace-roell <[email protected]>

* fix zoom test

Signed-off-by: jace-roell <[email protected]>

* auth handler init test

Signed-off-by: jace-roell <[email protected]>

* test

Signed-off-by: jace-roell <[email protected]>

* update main

Signed-off-by: jace-roell <[email protected]>

* patch coverage

Signed-off-by: jace-roell <[email protected]>

* changelog

Signed-off-by: jace-roell <[email protected]>

* test fix and unused map

Signed-off-by: jace-roell <[email protected]>

* fix broken mock

Signed-off-by: jace-roell <[email protected]>

* fix

Signed-off-by: jace-roell <[email protected]>

* remove only

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* move maxExtenderRetry to a setting instead of under table

Signed-off-by: jace-roell <[email protected]>

* track prompts by profile

Signed-off-by: jace-roell <[email protected]>

* rework to handle no profile object on profile uri

Signed-off-by: jace-roell <[email protected]>

* remove log statement

Signed-off-by: jace-roell <[email protected]>

* fix token check

Signed-off-by: jace-roell <[email protected]>

* init

Signed-off-by: jace-roell <[email protected]>

* fix inital auth prompt

Signed-off-by: jace-roell <[email protected]>

* test

Signed-off-by: jace-roell <[email protected]>

* fix void for init workspace

Signed-off-by: jace-roell <[email protected]>

* implement comment fixes, search after sso login

Signed-off-by: jace-roell <[email protected]>

* sso login after search dataset filter

Signed-off-by: jace-roell <[email protected]>

* shared init test fix

Signed-off-by: jace-roell <[email protected]>

* check before changing node collapisbleState

Signed-off-by: jace-roell <[email protected]>

* existing test fixes

Signed-off-by: jace-roell <[email protected]>

* patch cov

Signed-off-by: jace-roell <[email protected]>

* log statement

Signed-off-by: jace-roell <[email protected]>

* remove auth type none check

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* duplicate prompt

Signed-off-by: jace-roell <[email protected]>

* changelog

Signed-off-by: jace-roell <[email protected]>

* direct FS calls check profile type for auth prompt

Signed-off-by: jace-roell <[email protected]>

* remove timeout by default

Signed-off-by: jace-roell <[email protected]>

* address feedback

Signed-off-by: jace-roell <[email protected]>

* update setting name to Max Request Retry

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* awaitTimeout removal for some UssFs calls, retry wait, handleAuthError dont wait

Signed-off-by: jace-roell <[email protected]>

* test fixes

Signed-off-by: jace-roell <[email protected]>

* test commit

Signed-off-by: jace-roell <[email protected]>

* refactor: Wait for active request to resolve auth prompt

Signed-off-by: Trae Yelovich <[email protected]>

* update prompting behavior in FS to adhere to prompt description

Signed-off-by: Trae Yelovich <[email protected]>

* fix: remove extra lockProfile call in retry logic

Signed-off-by: Trae Yelovich <[email protected]>

* respect retry count

Signed-off-by: jace-roell <[email protected]>

* change timeout to 30s

Signed-off-by: jace-roell <[email protected]>

* wip(refactor): Queue FS requests until one succeeds for a profile

Signed-off-by: Trae Yelovich <[email protected]>

* fix: finish activating before fetching workspaces

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: skip .vscode calls in data set FS

Signed-off-by: Trae Yelovich <[email protected]>

* fix failing tests

Signed-off-by: jace-roell <[email protected]>

* add tests & typedoc for sequential/parallel handling

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add preceding slash to .vscode check in DS FS

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: release queued reqs after parallel mode re-enabled

Signed-off-by: Trae Yelovich <[email protected]>

* address lint errors

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: waitForUnlock no longer times out >30s

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Jace Roell <[email protected]>

* wip: remove request retry setting

Signed-off-by: jace-roell <[email protected]>

* remove try catch on canceled prompt

Signed-off-by: jace-roell <[email protected]>

* remove check for state of authentication - only consider cancellation

Signed-off-by: jace-roell <[email protected]>

* fix merge conflict and unused import

Signed-off-by: jace-roell <[email protected]>

* remove duplication in runSequentialIfEnabled catch block

Signed-off-by: Trae Yelovich <[email protected]>

* fix workspace extra prmopts

Signed-off-by: jace-roell <[email protected]>

* changelog update

Signed-off-by: jace-roell <[email protected]>

* fix changelog

Signed-off-by: jace-roell <[email protected]>

---------

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: Jace Roell <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: jace-roell <[email protected]>

* Fix auth check for ssh profiles (#3891)

* init

Signed-off-by: jace-roell <[email protected]>

* setting configuration

Signed-off-by: jace-roell <[email protected]>

* refactor retry

Signed-off-by: jace-roell <[email protected]>

* test updates

Signed-off-by: jace-roell <[email protected]>

* fix dataset provider function buff builder location

Signed-off-by: jace-roell <[email protected]>

* ds text fix

Signed-off-by: jace-roell <[email protected]>

* remove ds handleAuthCall

Signed-off-by: jace-roell <[email protected]>

* fix fs tests

Signed-off-by: jace-roell <[email protected]>

* usstree fix

Signed-off-by: jace-roell <[email protected]>

* fix zoom test

Signed-off-by: jace-roell <[email protected]>

* auth handler init test

Signed-off-by: jace-roell <[email protected]>

* test

Signed-off-by: jace-roell <[email protected]>

* update main

Signed-off-by: jace-roell <[email protected]>

* patch coverage

Signed-off-by: jace-roell <[email protected]>

* changelog

Signed-off-by: jace-roell <[email protected]>

* test fix and unused map

Signed-off-by: jace-roell <[email protected]>

* fix broken mock

Signed-off-by: jace-roell <[email protected]>

* fix

Signed-off-by: jace-roell <[email protected]>

* remove only

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* move maxExtenderRetry to a setting instead of under table

Signed-off-by: jace-roell <[email protected]>

* track prompts by profile

Signed-off-by: jace-roell <[email protected]>

* rework to handle no profile object on profile uri

Signed-off-by: jace-roell <[email protected]>

* remove log statement

Signed-off-by: jace-roell <[email protected]>

* fix token check

Signed-off-by: jace-roell <[email protected]>

* init

Signed-off-by: jace-roell <[email protected]>

* fix inital auth prompt

Signed-off-by: jace-roell <[email protected]>

* test

Signed-off-by: jace-roell <[email protected]>

* fix void for init workspace

Signed-off-by: jace-roell <[email protected]>

* implement comment fixes, search after sso login

Signed-off-by: jace-roell <[email protected]>

* sso login after search dataset filter

Signed-off-by: jace-roell <[email protected]>

* shared init test fix

Signed-off-by: jace-roell <[email protected]>

* check before changing node collapisbleState

Signed-off-by: jace-roell <[email protected]>

* existing test fixes

Signed-off-by: jace-roell <[email protected]>

* patch cov

Signed-off-by: jace-roell <[email protected]>

* log statement

Signed-off-by: jace-roell <[email protected]>

* remove auth type none check

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* duplicate prompt

Signed-off-by: jace-roell <[email protected]>

* changelog

Signed-off-by: jace-roell <[email protected]>

* direct FS calls check profile type for auth prompt

Signed-off-by: jace-roell <[email protected]>

* remove timeout by default

Signed-off-by: jace-roell <[email protected]>

* address feedback

Signed-off-by: jace-roell <[email protected]>

* update setting name to Max Request Retry

Signed-off-by: jace-roell <[email protected]>

* init

Signed-off-by: jace-roell <[email protected]>

* unused import

Signed-off-by: jace-roell <[email protected]>

* changelog

Signed-off-by: jace-roell <[email protected]>

* Update packages/zowe-explorer/CHANGELOG.md

Co-authored-by: anaxceron <[email protected]>
Signed-off-by: Jace Roell <[email protected]>

* awaitTimeout removal for some UssFs calls, retry wait, handleAuthError dont wait

Signed-off-by: jace-roell <[email protected]>

* test fixes

Signed-off-by: jace-roell <[email protected]>

* test commit

Signed-off-by: jace-roell <[email protected]>

* refactor: Wait for active request to resolve auth prompt

Signed-off-by: Trae Yelovich <[email protected]>

* update prompting behavior in FS to adhere to prompt description

Signed-off-by: Trae Yelovich <[email protected]>

* fix: remove extra lockProfile call in retry logic

Signed-off-by: Trae Yelovich <[email protected]>

* respect retry count

Signed-off-by: jace-roell <[email protected]>

* change timeout to 30s

Signed-off-by: jace-roell <[email protected]>

* wip(refactor): Queue FS requests until one succeeds for a profile

Signed-off-by: Trae Yelovich <[email protected]>

* fix: finish activating before fetching workspaces

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: skip .vscode calls in data set FS

Signed-off-by: Trae Yelovich <[email protected]>

* fix failing tests

Signed-off-by: jace-roell <[email protected]>

* add tests & typedoc for sequential/parallel handling

Signed-off-by: Trae Yelovich <[email protected]>

* fix: add preceding slash to .vscode check in DS FS

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: release queued reqs after parallel mode re-enabled

Signed-off-by: Trae Yelovich <[email protected]>

* address lint errors

Signed-off-by: Trae Yelovich <[email protected]>

* refactor: waitForUnlock no longer times out >30s

Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: Jace Roell <[email protected]>

* wip: remove request retry setting

Signed-off-by: jace-roell <[email protected]>

* remove try catch on canceled prompt

Signed-off-by: jace-roell <[email protected]>

* remove check for state of authentication - only consider cancellation

Signed-off-by: jace-roell <[email protected]>

* fix merge conflict and unused import

Signed-off-by: jace-roell <[email protected]>

* remove duplication in runSequentialIfEnabled catch block

Signed-off-by: Trae Yelovich <[email protected]>

* fix workspace extra prmopts

Signed-off-by: jace-roell <[email protected]>

* changelog update

Signed-off-by: jace-roell <[email protected]>

* move hasNoAuthType

Signed-off-by: jace-roell <[email protected]>

* fix tests

Signed-off-by: jace-roell <[email protected]>

* fix hasNoAuthType reference

Signed-off-by: jace-roell <[email protected]>

---------

Signed-off-by: jace-roell <[email protected]>
Signed-off-by: Jace Roell <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Co-authored-by: anaxceron <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Signed-off-by: jace-roell <[email protected]>

* update lerna

Signed-off-by: Billie Simmons <[email protected]>

---------

Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Billie Simmons <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Signed-off-by: Andrew W. Harn <[email protected]>
Signed-off-by: Trae Yelovich <[email protected]>
Signed-off-by: Dave Nice <[email protected]>
Signed-off-by: jace-roell <[email protected]>
Signed-off-by: likhithanimma1 <[email protected]>
Signed-off-by: Jace Roell <[email protected]>
Co-authored-by: Timothy Johnson <[email protected]>
Co-authored-by: Trae Yelovich <[email protected]>
Co-authored-by: Dave Nice <[email protected]>
Co-authored-by: Joshua Waters <[email protected]>
Co-authored-by: Jace Roell <[email protected]>
Co-authored-by: likhithanimma1 <[email protected]>
Co-authored-by: Fernando Rijo Cedeno <[email protected]>
Co-authored-by: anaxceron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Closed

9 participants