-
Notifications
You must be signed in to change notification settings - Fork 106
feat: Data set and USS download commands #3843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JWaters02
wants to merge
37
commits into
zowe:main
Choose a base branch
from
JWaters02:feat/download-ds
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 18 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
716e1bc
feat: command for downloading all members of PDS to local directory
JWaters02 72877ab
Attempt on tests
JWaters02 5bb37c1
Merge remote-tracking branch 'JWaters02/main' into feat/download-ds
JWaters02 08de650
refactor: smarter attempt at downloadAllMembers
JWaters02 ab2535a
store download options in local storage
JWaters02 f87c6b5
WIP
JWaters02 7a9b90f
Merge remote-tracking branch 'origin/main' into feat/download-ds
JWaters02 42fcb20
wip: downloading
JWaters02 c4eaeb4
Merge remote-tracking branch 'origin/main' into feat/download-ds
JWaters02 7ea6ff2
wip: downloading
JWaters02 8eafadb
wip: downloading
JWaters02 d230ec0
wip: add downloadDataSet and move common quickpick to helper
JWaters02 116d596
refactor: reduce code duplication
JWaters02 2d2b5ac
Merge remote-tracking branch 'origin/main' into feat/download-ds
JWaters02 fa100fb
feat: download uss files/directories
JWaters02 5f81fc3
fix: count dir children recursively
JWaters02 17fc579
Merge remote-tracking branch 'origin/main' into feat/download-ds
JWaters02 a663383
Merge remote-tracking branch 'origin/main' into feat/download-ds
JWaters02 9c6c4ed
refactor: fallback to profile encoding
JWaters02 4a039fc
Merge remote-tracking branch 'origin/main' into feat/download-ds
JWaters02 ed79831
fix: implement downloadAllDatasets into FtpMvsApi
JWaters02 a003177
tests: update command count
JWaters02 11beac6
tests: all tests passing, ready for Download test cases
JWaters02 5c15080
tests: data set download functions tests
JWaters02 efb87ef
tests: uss download functions tests
JWaters02 e8bce59
tests: add USSUtils.unit.test.ts with coverage for existing & new funcs
JWaters02 e25d90f
tests: USSInit & DatasetInit coverage
JWaters02 03fa91e
tests: remove unused imports
JWaters02 a3de6fd
refactor: add downloadDirectory to IUss interface
JWaters02 cab987b
tests: add mvs/uss download api impl to ftp ext tests
JWaters02 5da1f2a
wip: add list opts support to uss dir download
JWaters02 9bf9a9d
refactor: uss dir download options
JWaters02 10a1ce7
refactor: handle download responses properly
JWaters02 6f636e2
Merge branch 'feat/download-uss-dir-opts' into feat/download-ds
JWaters02 a61fa6f
tests: fix tests and add new tests for the changes
JWaters02 a44a6ba
refactor: change context menu groupings
JWaters02 1b06aad
chore: prepublish
JWaters02 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -243,42 +243,6 @@ | |
| "Uploading USS files...": "Uploading USS files...", | ||
| "Error uploading files": "Error uploading files", | ||
| "Retrieving response from USS list API": "Retrieving response from USS list API", | ||
| "The 'move' function is not implemented for this USS API.": "The 'move' function is not implemented for this USS API.", | ||
| "Failed to move {0}/File path": { | ||
| "message": "Failed to move {0}", | ||
| "comment": [ | ||
| "File path" | ||
| ] | ||
| }, | ||
| "Profile does not exist for this file.": "Profile does not exist for this file.", | ||
| "Saving USS file...": "Saving USS file...", | ||
| "Failed to rename {0}/File path": { | ||
| "message": "Failed to rename {0}", | ||
| "comment": [ | ||
| "File path" | ||
| ] | ||
| }, | ||
| "Failed to delete {0}/File name": { | ||
| "message": "Failed to delete {0}", | ||
| "comment": [ | ||
| "File name" | ||
| ] | ||
| }, | ||
| "No error details given": "No error details given", | ||
| "Error fetching destination {0} for paste action: {1}/USS pathError message": { | ||
| "message": "Error fetching destination {0} for paste action: {1}", | ||
| "comment": [ | ||
| "USS path", | ||
| "Error message" | ||
| ] | ||
| }, | ||
| "Failed to copy {0} to {1}/Source pathDestination path": { | ||
| "message": "Failed to copy {0} to {1}", | ||
| "comment": [ | ||
| "Source path", | ||
| "Destination path" | ||
| ] | ||
| }, | ||
| "Downloaded: {0}/Download time": { | ||
| "message": "Downloaded: {0}", | ||
| "comment": [ | ||
|
|
@@ -341,6 +305,42 @@ | |
| "initializeUSSFavorites.error.buttonRemove": "initializeUSSFavorites.error.buttonRemove", | ||
| "File does not exist. It may have been deleted.": "File does not exist. It may have been deleted.", | ||
| "Pulling from Mainframe...": "Pulling from Mainframe...", | ||
| "The 'move' function is not implemented for this USS API.": "The 'move' function is not implemented for this USS API.", | ||
| "Failed to move {0}/File path": { | ||
| "message": "Failed to move {0}", | ||
| "comment": [ | ||
| "File path" | ||
| ] | ||
| }, | ||
| "Profile does not exist for this file.": "Profile does not exist for this file.", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we say "A profile ... "? |
||
| "Saving USS file...": "Saving USS file...", | ||
| "Failed to rename {0}/File path": { | ||
| "message": "Failed to rename {0}", | ||
| "comment": [ | ||
| "File path" | ||
| ] | ||
| }, | ||
| "Failed to delete {0}/File name": { | ||
| "message": "Failed to delete {0}", | ||
| "comment": [ | ||
| "File name" | ||
| ] | ||
| }, | ||
| "No error details given": "No error details given", | ||
| "Error fetching destination {0} for paste action: {1}/USS pathError message": { | ||
| "message": "Error fetching destination {0} for paste action: {1}", | ||
| "comment": [ | ||
| "USS path", | ||
| "Error message" | ||
| ] | ||
| }, | ||
| "Failed to copy {0} to {1}/Source pathDestination path": { | ||
| "message": "Failed to copy {0} to {1}", | ||
| "comment": [ | ||
| "Source path", | ||
| "Destination path" | ||
| ] | ||
| }, | ||
| "{0} location/Node type": { | ||
| "message": "{0} location", | ||
| "comment": [ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -706,15 +706,6 @@ | |||||
| "Uploading USS files...": "", | ||||||
| "Error uploading files": "", | ||||||
| "Retrieving response from USS list API": "", | ||||||
| "The 'move' function is not implemented for this USS API.": "", | ||||||
| "Failed to move {0}": "", | ||||||
| "Profile does not exist for this file.": "", | ||||||
| "Saving USS file...": "", | ||||||
| "Failed to rename {0}": "", | ||||||
| "Failed to delete {0}": "", | ||||||
| "No error details given": "", | ||||||
| "Error fetching destination {0} for paste action: {1}": "", | ||||||
| "Failed to copy {0} to {1}": "", | ||||||
| "Downloaded: {0}": "", | ||||||
| "Encoding: {0}": "", | ||||||
| "Binary": "", | ||||||
|
|
@@ -741,6 +732,15 @@ | |||||
| "initializeUSSFavorites.error.buttonRemove": "", | ||||||
| "File does not exist. It may have been deleted.": "", | ||||||
| "Pulling from Mainframe...": "", | ||||||
| "The 'move' function is not implemented for this USS API.": "", | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| "Failed to move {0}": "", | ||||||
| "Profile does not exist for this file.": "", | ||||||
| "Saving USS file...": "", | ||||||
| "Failed to rename {0}": "", | ||||||
| "Failed to delete {0}": "", | ||||||
| "No error details given": "", | ||||||
| "Error fetching destination {0} for paste action: {1}": "", | ||||||
| "Failed to copy {0} to {1}": "", | ||||||
| "{0} location": "", | ||||||
| "Choose a location to create the {0}": "", | ||||||
| "Name of file or directory": "", | ||||||
|
|
||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.