Skip to content

Conversation

@pujal0909
Copy link
Contributor

@pujal0909 pujal0909 commented Oct 21, 2025

Proposed changes

Fixes #3897

Release Notes

Milestone:

Changelog:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which adds or improves functionality)
  • Breaking change (a change that would cause existing functionality to not work as expected)
  • Documentation (Markdown, README updates)
  • Other (please specify above in "Proposed changes" section)

Checklist

General

  • I have read the CONTRIBUTOR GUIDANCE wiki
  • All PR dependencies have been merged and published (if applicable)
  • A GIF or screenshot is included in the PR for visual changes
  • The pre-publish command has been executed:
    • v2 and below: yarn workspace vscode-extension-for-zowe vscode:prepublish
    • v3: pnpm --filter vscode-extension-for-zowe vscode:prepublish
  • New ZE APIs are tested with extender types that haven't adopted yet to determine breaking changes. Can use Zowe zFTP marketplace extension.

Code coverage

  • There is coverage for the code that I have added
  • I have added new test cases and they are passing
  • I have manually tested the changes

Deployment

  • I have tested new functionality with the FTP extension and profile verifying no extender profile type breakages introduced
  • I have added developer documentation (if applicable)
  • Documentation should be added to Zowe Docs
    • If you're an outside contributor, please post in the #zowe-doc Slack channel to coordinate documentation.
    • Otherwise, please check with the rest of the squad about any needed documentation before merging.
  • These changes may need ported to the appropriate branches (list here):

Further comments

Signed-off-by: Pujal <[email protected]>
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

zowe-explorer-vsix Download
Build Details
Name Information
PR Commit 6ab26c5
Merge Commit a5311e1
Size 3.7 MB
Last Updated By pujal0909
Last Updated Oct 31, 25, 1:34:14 PM UTC
Expires At Jan 29, 26, 1:32:20 PM UTC

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.04%. Comparing base (8474805) to head (6ab26c5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3908      +/-   ##
==========================================
- Coverage   94.04%   94.04%   -0.01%     
==========================================
  Files         129      129              
  Lines       15593    15595       +2     
  Branches     3562     3770     +208     
==========================================
+ Hits        14665    14666       +1     
- Misses        926      927       +1     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pujal0909 pujal0909 marked this pull request as ready for review October 21, 2025 20:00
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code Oct 21, 2025
@github-actions
Copy link

github-actions bot commented Oct 21, 2025

📅 Suggested merge-by date: 11/5/2025

@pujal0909 pujal0909 marked this pull request as draft October 22, 2025 15:11
@zowe-robot zowe-robot moved this from Review/QA to In Progress in Zowe Explorer for VS Code Oct 22, 2025
Signed-off-by: Pujal <[email protected]>
@pujal0909 pujal0909 marked this pull request as ready for review October 22, 2025 15:24
@zowe-robot zowe-robot moved this from In Progress to Review/QA in Zowe Explorer for VS Code Oct 22, 2025
@pujal0909 pujal0909 requested a review from anaxceron October 22, 2025 15:41
@pujal0909 pujal0909 requested a review from traeok October 23, 2025 14:01
traeok
traeok previously requested changes Oct 23, 2025
Signed-off-by: Pujal <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 28, 2025
@pull-request-size pull-request-size bot added size/S and removed size/M labels Oct 28, 2025
@pujal0909 pujal0909 requested a review from traeok October 28, 2025 20:30
Signed-off-by: Pujal <[email protected]>
@traeok traeok dismissed their stale review October 29, 2025 14:48

Changes addressed

Signed-off-by: Pujal <[email protected]>
Signed-off-by: Pujal <[email protected]>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 30, 2025
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion but changes make sense to me 👍

@pujal0909 pujal0909 requested a review from traeok October 31, 2025 13:32
Copy link
Member

@traeok traeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pujal, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Review/QA

Development

Successfully merging this pull request may close these issues.

Deleting PDS while it's open results in error message

4 participants