Add configurable setting for job delete confirmation dialog by BRGOVIND · Pull Request #4327 · zowe/zowe-explorer-vscode

BRGOVIND · 2026-06-11T18:22:00Z

Proposed changes

Resolves #4315

Adds a new VS Code setting, zowe.jobs.confirmDelete, that allows users to disable the job deletion confirmation dialog.

The setting defaults to true, preserving the current behavior. When disabled, users can delete jobs without being prompted for confirmation.

The setting is applied to both single-job and multi-job deletion workflows.

Release Notes

Milestone: TBD

Changelog:

Added zowe.jobs.confirmDelete setting to control whether users are prompted before deleting jobs.

Types of changes

Enhancement (non-breaking change which adds or improves functionality)

Checklist

General

I have read the CONTRIBUTOR GUIDANCE wiki
All PR dependencies have been merged and published (if applicable)
A GIF or screenshot is included in the PR for visual changes
The pre-publish command has been executed
New ZE APIs are tested with extender types that haven't adopted yet to determine breaking changes

Code coverage

There is coverage for the code that I have added
I have added new test cases and they are passing
I have manually tested the changes

Deployment

I have tested new functionality with the FTP extension and profile verifying no extender profile type breakages introduced
I have added developer documentation (if applicable)
Documentation should be added to Zowe Docs
These changes may need ported to the appropriate branches

Further comments

The existing delete confirmation behavior remains unchanged by default. The new setting provides an option for power users and enables easier automation and end-to-end testing scenarios where interactive confirmation dialogs are undesirable.

zFernand0

Please address failing tests
https://github.com/zowe/zowe-explorer-vscode/actions/runs/27552741216/job/81443298737?pr=4327#step:7:289

t1m0thyj

Thanks for your work on this @BRGOVIND! Left a few comments

t1m0thyj · 2026-06-17T12:20:29Z

+const confirmDelete = vscode.workspace
+    .getConfiguration()
+    .get<boolean>("zowe.jobs.confirmDelete", true);
+
+if (confirmDelete) {
+    const deleteChoice = await Gui.warningMessage(message, {
+        items: [deleteButton],
+        vsCodeOpts: { modal: true },
+    });
+
+    if (!deleteChoice || deleteChoice === "Cancel") {
+        ZoweLogger.debug(vscode.l10n.t("Delete action was canceled."));
+        Gui.showMessage(vscode.l10n.t("Delete action was cancelled."));
+        return;
+    }
+}


Please keep the indentation of this code block consistent with the rest of the file.

t1m0thyj · 2026-06-17T12:22:15Z


 ### New features and enhancements

+- Added a new VS Code toggle setting `zowe.jobs.confirmDelete` that allows users to disable the job deletion confirmation dialog. [#4315](https://github.com/zowe/zowe-explorer-vscode/issues/4315)


@traeok Maybe outside the scope of this PR, but I noticed the issue mentions the confirmDelete setting only for the Jobs tree. Wouldn't it be useful to have across all the trees?

t1m0thyj · 2026-06-17T12:23:21Z

+        "zowe.jobs.confirmDelete": {
+              "type": "boolean",
+              "default": true,
+              "description": "Prompt for confirmation before deleting jobs.",


Please localize this string by using the same style of placeholder as other setting descriptions and define the description in package.nls.json.

BRGOVIND · 2026-06-19T10:34:02Z

Thanks for the detailed review @t1m0thyj! I've addressed the feedback:

Indentation (JobActions.ts): the confirmDelete guard blocks are now indented consistently with the rest of the file in both deleteCommand and deleteMultipleJobs.
Localization (package.json): the setting description now uses the %zowe.jobs.confirmDelete% placeholder, with the string defined in package.nls.json, matching the other settings.
Failing tests: the test mock for getConfiguration is reset in beforeEach so the confirmDelete default no longer leaks between suites; added a case covering confirmDelete = false.
Rebased onto latest main to resolve the CHANGELOG conflict.

Re the cross-tree confirmDelete idea — agreed it'd be useful, but I'd suggest keeping it out of scope here and tracking it as a follow-up so this stays focused on the Jobs tree (#4315). Re-requesting review when you have a moment 🙏

BRGOVIND · 2026-06-27T02:54:13Z

Rebased again on latest main — the CHANGELOG conflict is resolved and the branch is mergeable. All earlier feedback (indentation, %zowe.jobs.confirmDelete% localization, and the test mock leak) remains addressed. Re-requesting review, thanks! 🙏

…ialog - Add zowe.jobs.confirmDelete boolean setting (default: true) to allow users to skip the confirmation dialog when deleting jobs - Localize description via package.nls.json placeholder - Fix indentation of confirmation logic in deleteSingleJob/deleteMultipleJobs - Add CHANGELOG entry for the new setting

traeok · 2026-06-30T15:08:24Z

There is one commit incorrectly signed off, triggering DCO failures. Can you please add a sign off to your latest commit?

zFernand0

Changes LGTM! 😋

I'd recommend avoiding force pushing since that makes things harder for reviewers.

Also, before I can approve, I'd like to have you join standup to discuss the progression of this PR. 🙏

BRGOVIND · 2026-06-30T17:41:19Z

@traeok
I, BRGOVIND, hereby sign-off-by all my previous commits in this PR as per the terms of the DCO.

BRGOVIND · 2026-06-30T17:41:31Z

@zFernand0
Thank you for the review! I'll join standup to discuss the PR. And noted on avoiding force pushes going forward.

zFernand0 · 2026-07-08T17:59:38Z

@zFernand0 Thank you for the review! I'll join standup to discuss the PR. And noted on avoiding force pushes going forward.

Forgot to mention that we have a stand-up for Zowe Explorer on Tuesdays and Thursdays at 11am EDT.
https://zoom-lfx.platform.linuxfoundation.org/meetings/zowe

zFernand0 · 2026-07-21T15:15:22Z

Hey @BRGOVIND,
The DCO check is still failing.
Also, we would want to you to join standup before we can proceed with this PR : )

BRGOVIND requested review from JillieBeanSim, t1m0thyj and zFernand0 as code owners June 11, 2026 18:22

github-project-automation Bot added this to Zowe Explorer for VS Code Jun 11, 2026

github-project-automation Bot moved this to New Issues in Zowe Explorer for VS Code Jun 11, 2026

pull-request-size Bot added the size/M label Jun 11, 2026

zowe-robot moved this from New Issues to Review/QA in Zowe Explorer for VS Code Jun 11, 2026

zFernand0 requested changes Jun 15, 2026

View reviewed changes

BRGOVIND requested a review from anaxceron as a code owner June 16, 2026 03:25

JTonda requested a review from zFernand0 June 16, 2026 15:14

anaxceron approved these changes Jun 16, 2026

View reviewed changes

t1m0thyj requested changes Jun 17, 2026

View reviewed changes

BRGOVIND force-pushed the feature/job-delete-confirmation-setting branch from 8f6def3 to f294f35 Compare June 19, 2026 10:33

JTonda requested a review from t1m0thyj June 23, 2026 15:11

BRGOVIND force-pushed the feature/job-delete-confirmation-setting branch from 8ce4c3a to ecc9e7f Compare June 29, 2026 15:42

zFernand0 reviewed Jun 30, 2026

View reviewed changes


		### New features and enhancements

		- Added a new VS Code toggle setting `zowe.jobs.confirmDelete` that allows users to disable the job deletion confirmation dialog. [#4315](https://github.com/zowe/zowe-explorer-vscode/issues/4315)

Uh oh!

Conversation

BRGOVIND commented Jun 11, 2026

Proposed changes

Release Notes

Types of changes

Checklist

General

Code coverage

Deployment

Further comments

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

Uh oh!

t1m0thyj left a comment

Choose a reason for hiding this comment

Uh oh!

t1m0thyj Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

t1m0thyj Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

t1m0thyj Jun 17, 2026

Choose a reason for hiding this comment

Uh oh!

BRGOVIND commented Jun 19, 2026

Uh oh!

BRGOVIND commented Jun 27, 2026

Uh oh!

traeok commented Jun 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zFernand0 left a comment

Choose a reason for hiding this comment

Changes LGTM! 😋

Uh oh!

BRGOVIND commented Jun 30, 2026

Uh oh!

BRGOVIND commented Jun 30, 2026

Uh oh!

zFernand0 commented Jul 8, 2026

Uh oh!

zFernand0 commented Jul 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

traeok commented Jun 30, 2026 •

edited

Loading