Default to bring your own keyring #4238
Conversation
|
build 7193 SUCCEEDED. |
zowe-robot
had a problem deploying
to
marist-zzow11
GitHub Actions
Failure
|
Test workflow 6252 is started. |
|
build 7194 SUCCEEDED. |
zowe-robot
had a problem deploying
to
marist-zzow09
GitHub Actions
Failure
|
Test workflow 6253 is started. |
|
To avoid users needing to duplicate information, could we adjust the init certifcate command so it takes both a zowe.yaml configuration file and a cert scenario file?
|
bin/commands/init/index.sh
Outdated
| zwecli_inline_execute_command init security | ||
| fi | ||
| zwecli_inline_execute_command init certificate | ||
| if [ "${ZWE_CLI_PARAMETER_CREATE_CERTIFICATE}" != "true" ]; then |
There was a problem hiding this comment.
- Should check for "is equal":
if [ "${ZWE_CLI_PARAMETER_CREATE_CERTIFICATE}" = "true" ]; then - This is a braking change as the new default is "Do not process certificates".
|
build 7207 SUCCEEDED. |
zowe-robot
had a problem deploying
to
marist-zzow09
GitHub Actions
Failure
|
Test workflow 6264 is started. |
|
build 7209 SUCCEEDED. |
zowe-robot
had a problem deploying
to
marist-zzow11
GitHub Actions
Failure
|
Test workflow 6266 is started. |
|
build 7212 SUCCEEDED. |
zowe-robot
had a problem deploying
to
marist-zzow10
GitHub Actions
Failure
|
Test workflow 6270 is started. |
|
build 7316 SUCCEEDED. |
|
build 7317 SUCCEEDED. |
zowe-robot
had a problem deploying
to
marist-zzow09
GitHub Actions
Failure
|
Test workflow 6328 is started. |
zowe-robot
had a problem deploying
to
marist-zzow11
GitHub Actions
Failure
|
Test workflow 6330 is started. |
Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
|
Test workflow 6758 is started. |
|
Test workflow 6759 is started. |
Signed-off-by: Martin Zeithaml <[email protected]>
Martin-Zeithaml
had a problem deploying
to
marist-zzow10
GitHub Actions
Failure
Martin-Zeithaml
had a problem deploying
to
marist-zzow11
GitHub Actions
Failure
|
build 7881 SUCCEEDED. |
|
build 7882 SUCCEEDED. |
|
Test workflow 6770 is started. |
|
Test workflow 6771 is started. |
|
The changes look good. Before merging this in:
I can take a look at the second question. |
Signed-off-by: 1000TurquoisePogs <[email protected]>
1000TurquoisePogs
had a problem deploying
to
marist-zzow10
GitHub Actions
Failure
1000TurquoisePogs
had a problem deploying
to
marist-zzow11
GitHub Actions
Failure
|
build 7901 FAILED. |
|
build 7902 FAILED. |
Signed-off-by: 1000TurquoisePogs <[email protected]>
1000TurquoisePogs
had a problem deploying
to
marist-zzow10
GitHub Actions
Failure
|
build 7904 FAILED. |
1000TurquoisePogs
had a problem deploying
to
marist-zzow11
GitHub Actions
Failure
|
build 7926 FAILED. |
This PR changes the default behavior of
zwe initto no longer runzwe init certificate, and moves allzowe.setup.certificatecontent away from the example-zowe.yaml and into a new folder zowe/files/examples/setup/certificateWith this PR, to create certificates in a new zowe install,
zwe initis not enough anymore!Users must use the contents of zowe/files/examples/setup/certificate and then run either
zwe init --create-certificateorzwe init certificateThe purpose is to have the YAML and
zwe initmeet users expectations better.Many users bring their own keyrings when doing a zowe setup, yet they end up for some reason running certificate setup anyway. They may encounter errors, or at least end up with something they didn't want.
Further, users often get confused between the difference of
zowe.setup.certificateandzowe.certificate. So, if they get confused by the one they do not want to use anyway, why not move it?This PR is not a breaking change in the sense that it does not disrupt existing installs.
I do not believe a HOLD statement is needed.
However, new installs will no longer get certificates created by default.
So, documentation will need to call out that as an action item for those who do want that, unpopular as it is.
The new example yaml references the location of the setup certificate example yamls, and they contain comments within that explain how to use them.
I have made a slight edit to
zwe init certificateto make these YAML as small as possible: I found thatzowe.setup.dataset.prefixwas needed for keyring creation, but not for pkcs12 creation, so I moved it into the appropriate block.