Skip to content

Conversation

@1000TurquoisePogs
Copy link
Member

@1000TurquoisePogs 1000TurquoisePogs commented May 10, 2025

This PR is a PoC of having the majority of zwe run in TS rather than shell.
It affects operations such as --help, being much faster. Basically every command is faster because a lot of shell stuff is skipped.
This is mostly a 1-to-1 rewrite, but during the rewrite I found code that was doing things never implemented, so I took some liberties to make cleaner code.

It has several exclusions and likely needs more - when a non --help operation is done, a --config is needed. So, if an operation has no --config, this new code should not run and you should see the old code execute instead.

I've also tried to exclude commands that aren't written in TS yet.

The design has a limitation. quickjs cannot do conditional or dynamic imports, so you need to import every command, and that brings in the requirement to have a configuration file specified.
I am trying to work around this by giving a dummy config file to those commands that dont need it.

DO NOT MERGE. It is just a PoC.

…shell overhead in command processing

Signed-off-by: 1000TurquoisePogs <[email protected]>
Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented May 10, 2025

build 7630 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/14944174712

@github-actions
Copy link

github-actions bot commented May 10, 2025

Test workflow 6599 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.2.0-PR-4325/zowe-3.2.0-pr-4325-7630-20250510094535.pax
Running on machine: zzow10
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/14944197676

@github-actions
Copy link

github-actions bot commented May 11, 2025

build 7633 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/14953601717

@github-actions
Copy link

github-actions bot commented May 11, 2025

Test workflow 6602 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.2.0-PR-4325/zowe-3.2.0-pr-4325-7633-20250511073550.pax
Running on machine: zzow09
Result: FAILURE
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/14953621620

Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented May 11, 2025

build 7634 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/14955493273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants