Skip to content

Conversation

@1000TurquoisePogs
Copy link
Member

This PR adds sensitivity to the "TZ" env var to "zwe", as well as points to zowe/zlux-server-framework#572 which does the same for app-server.

the property zowe.logging.timezone, when set to "LOCAL" or "local", will effect them.

There's a small bootstrapping problem to be solved in the TS code - when is "zowe.logging.timezone" readable? If its set as an env var, the TS code will use it, but it doesn't get set as an env var until some point of execution. This sets it as soon as configmgr is called, but a user could set the env var by some other means too.

Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

build 8777 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18019464992

Signed-off-by: 1000TurquoisePogs <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 25, 2025

build 8778 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18019495733

@github-actions
Copy link

github-actions bot commented Sep 25, 2025

build 8779 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18019504475

@github-actions
Copy link

github-actions bot commented Sep 26, 2025

build 8784 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18038839624

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

build 8827 FAILED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18131219285

Signed-off-by: Martin Zeithaml <[email protected]>
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

build 8832 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18132146728

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

build 8833 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18132203778

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Test workflow 7517 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.4.0-PR-4520/zowe-3.4.0-pr-4520-8832-20250930135506.pax
Running on machine: zzow09
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18132360428

@github-actions
Copy link

github-actions bot commented Sep 30, 2025

Test workflow 7520 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.4.0-PR-4520/zowe-3.4.0-pr-4520-8833-20250930135904.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18132467676

@Martin-Zeithaml
Copy link
Contributor

# ./yaml/zowe.wrong.yaml
zowe:
  logging:
    timezone: Prague
# ./yaml/zowe.local.yaml
zowe:
  logging:
    timezone: LOCAL
# ./yaml/zowe.utc.yaml
zowe:
  logging:
    timezone: UTC
# ./yaml/zowe.none.yaml
zowe:
  environments:
    1: 1
$ /zowe/4520/bin/zwe config validate --config ./yaml/zowe.wrong.yaml
Error: Validation of FILE(./yaml/zowe.wrong.yaml):FILE(/zowe/4520/files/defaults.yaml) against schema /zowe/4520/schemas/zowe-yaml-schema.json:/zowe/4520/schemas/server-common.json found invalid JSON Schema data
Validity Exceptions(s) with object at
  Validity Exceptions(s) with object at /zowe
    Validity Exceptions(s) with object at /zowe/logging
      no matching enum value at /zowe/logging/timezone; expecting one of values '[LOCAL, UTC]' of type 'string'

$ /zowe/4520/bin/zwe config validate --config ./yaml/zowe.local.yaml
2025-09-30 10:58:36 <ZWELS:33883244> USERID INFO (zwe-internal-start-prepare) Zowe version: v3.4.0
2025-09-30 10:58:36 <ZWELS:33883244> USERID INFO (zwe-internal-start-prepare) build and hash: PR-4520#8832 (d168e37072904dce3c94ed47e7e5aa96322cacc2)
Validating Zowe core configuration for file(s)=/tmp/.zweenv-1169/.zowe-merged.yaml
Zowe core configuration is valid

$ /zowe/4520/bin/zwe config validate --config ./yaml/zowe.utc.yaml
2025-09-30 16:58:47 <ZWELS:67438457> USERID INFO (zwe-internal-start-prepare) Zowe version: v3.4.0
2025-09-30 16:58:47 <ZWELS:67438457> USERID INFO (zwe-internal-start-prepare) build and hash: PR-4520#8832 (d168e37072904dce3c94ed47e7e5aa96322cacc2)
Validating Zowe core configuration for file(s)=/tmp/.zweenv-2694/.zowe-merged.yaml
Zowe core configuration is valid

$ /zowe/4520/bin/zwe config validate --config ./yaml/zowe.none.yaml
2025-09-30 16:58:58 <ZWELS:17106650> USERID INFO (zwe-internal-start-prepare) Zowe version: v3.4.0
2025-09-30 16:58:58 <ZWELS:17106650> USERID INFO (zwe-internal-start-prepare) build and hash: PR-4520#8832 (d168e37072904dce3c94ed47e7e5aa96322cacc2)
Validating Zowe core configuration for file(s)=/tmp/.zweenv-8680/.zowe-merged.yaml
Zowe core configuration is valid

The timestamp difference between LOCAL and UTC (or with no logging setting) corresponds to date '+%z'.

Copy link
Contributor

@Martin-Zeithaml Martin-Zeithaml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature should be in CHANGELOG.

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

build 8841 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18157968927

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

Test workflow 7526 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.4.0-PR-4520/zowe-3.4.0-pr-4520-8841-20251001094017.pax
Running on machine: zzow10
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18158106933

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

build 8851 SUCCEEDED.
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18167954626

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

Test workflow 7535 is started.
Running install test: Convenience Pax
The zowe artifact being used by this test workflow: libs-snapshot-local/org/zowe/3.4.0-PR-4520/zowe-3.4.0-pr-4520-8851-20251001155848.pax
Running on machine: zzow11
Result: SUCCESS
Link to workflow run: https://github.com/zowe/zowe-install-packaging/actions/runs/18168070527

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants