Skip to content

Conversation

@jt-nti
Copy link
Contributor

@jt-nti jt-nti commented Sep 26, 2025

example.com is reserved for documentation purposes and avoids any potential problems that might occur if ficticious names are actually registered

Please check if your PR fulfills the following requirements. This is simply a reminder of what we are going to look for before merging your PR. If you don't know all of this information when you create this PR, don't worry. You can edit this template as you're working on it.

  • Tests for the changes have been added (for bug fixes / features)
  • Necessary documentation (if appropriate) have been added / updated
  • DCO signoffs have been added to all commits, including this PR

PR type

What type of changes does your PR introduce to Zowe? Put an x in the box that applies to this PR. If you're unsure about any of them, don't hesitate to ask.

  • Bugfix
  • Feature
  • Other... Please describe: doc/sample/workflow changes

Relevant issues

Related to zowe/docs-site#4727

Changes proposed in this PR

  • replace fictitious domains with example.com

Does this PR introduce a breaking change?

  • Yes
  • No 🤞

Does this PR add or change a YAML parameter?

  • Yes
  • No

Does this PR do something the person installing Zowe should know about?

No

Is there a related doc issue or Pull Request?

Doc issue/PR number: this is a doc PR

Other information

example.com is reserved for documentation purposes and avoids any
potential problems that might occur if ficticious names are actually
registered

Signed-off-by: James Taylor <[email protected]>
@JoeNemo
Copy link
Contributor

JoeNemo commented Oct 1, 2025

This PR seems benign, helpful, and consistent. However, we do need to check if there is any fanout to automation or documentation.

@jt-nti
Copy link
Contributor Author

jt-nti commented Oct 1, 2025

Thanks @JoeNemo, hopefully I've caught everything in the main documentation with zowe/docs-site#4727, although I wasn't 100% certain how the doc that @Martin-Zeithaml mentioned in zowe/docs-site#4727 (comment) makes it over there, or whether there might be other places around that I've missed.

@MarkAckert MarkAckert self-requested a review October 1, 2025 17:09
@MarkAckert
Copy link
Member

These changes look OK to me, and shouldn't have any negative consequence, but I'm going to review the test cases before merging this in.

In order to keep these changes and the doc in sync, can you please change the merge target in docs-site to docs-staging? And mark the release in docs-staging for 3.4.0 ? I'll add the same comment there. Thx

@MarkAckert
Copy link
Member

Merging in; the build failure is due to permissions errors in the workflow caused by this PR being opened from a fork. The changes look OK, better support for PRs from forks will need to be added at a later time.

@MarkAckert MarkAckert merged commit bab9b37 into zowe:v3.x/staging Oct 9, 2025
21 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants