Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add more command handlers, cleanup code, support error response #143

Open
wants to merge 48 commits into
base: main
Choose a base branch
from
Open

feat: Add more command handlers, cleanup code, support error response #143

wants to merge 48 commits into from

Conversation

traeok
Copy link
Member

@traeok traeok commented Feb 20, 2025 •
edited
Loading

What It Does

  • Adds the following USS command handlers to ioserver:
    • chmodFile, chownFile, chtagFile, createFile, deleteFile
  • Adds the following Job command handlers to ioserver:
    • cancelJob, deleteJob, submitJcl, submitJob
  • Implements the following changes in zowex:
    • new USS functionalities: chown, chtag
    • new Job functionality: Submit JCL from stdin
    • Refactored zjb_submit to support submitting JCL contents directly and from DSN
    • Adds support for mkdir -p behavior (recursively creates missing inner directories) when making a new USS directory
    • Adds support for recursive option in chmod/chown/chtag operations
  • Adds the following commands and groups to zssh:
    • cancel: job
    • delete: uss-file, uss-dir
    • submit: job
    • unix: chmod, chown, chtag
  • Adds error handling to Go layer to properly forward JSON-serialized errors to client (for further processing)

How to Test

Review Checklist
I certify that I have:

Additional Comments

traeok added 30 commits February 10, 2025 11:22
@traeok
feat(ioserver): delete dataset command handler
25ae8f4 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
fix(zowex): complete USS delete cmd handler
f78eb62 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
feat(ioserver): Delete file command handler
ad719d5 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
feat: chown functionality in ioserver and zowex
99a4472 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
refactor: chmod recursive support and add to ioserver
973f0de 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
doc: add comments to Go code and types
5355ca2 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
types: rebuild TS types to pick up comments
0fc5cd4 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: chtag implementation (backend & middleware)
4d7164e 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
refactor: add PrintCommandResponse fn, cleanup handlers
3d43258 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
Merge branch 'main' into feat/more-handlers
0e89369 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
merge in changes from main
1a57e77 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
Merge branch 'main' into feat/more-handlers
5e2da8d 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
feat: recursive uss chmod
8a93fd5 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: recursive chown, recursive chtag
cb93b12 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
feat: create uss dir & file
0b13b21 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: cancel, delete, submit job in middleware
5e97fe3 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
update TS types and add SDK funcs
c97f871 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: support chtag using chattr
0de0873 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
fix chtag includes; update recursive description
2a45d7b 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
doc: update apis.md
ac23b11 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
refactor: check mkdir rc for create dir; add mkdirp support
0dd8ccd 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip(uss): action logic for VSCE; update types
ebc1bdb 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: add jobId to SubmitJobResponse
3101b5d 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
doc: update apis.md
eb52ad0 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: job submit logic and type updates
eea7eec 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
zowex: job submit command handler
64a361e 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: create data set logic
00a66cb 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
chore: reorder command handler map
7875d70 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: common code for cmd handlers, fwd errors
b095d21 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
refactor: update request & response types
f21c24a 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
fix(zjb.hpp): string -> std::string
9bd1540 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
add missing handlers, use %v for error fmt
ccd2bea 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
Merge branch 'main' into feat/more-handlers
f7dde0a 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
Merge branch 'main' into feat/more-handlers
f4db9e4 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
wip: handle results truncated error in go
0c129a1 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
fix: use submitJcl in command instead of submitJob
b4a44aa 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
refactor: make response types extend CommandResponse
b4ad67d 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
refactor: getStatus -> getJobStatus, add SshJesApi.getJob
92dbe0c 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
remove console log
1322718 
Signed-off-by: Trae Yelovich <[email protected]>
dkelosky
dkelosky reviewed Feb 20, 2025
View reviewed changes
@traeok traeok force-pushed the feat/more-handlers branch from 9076c36 to fd4d12e Compare February 20, 2025 23:47
@traeok
refactor: separate cmd init by resource type
3b374a8 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
refactor: doc, truncate log file if >10MB
80da449 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
feat(cli): uss chown,chmod,chtag
9242843 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok
feat(cli): add multiple commands
7430cca 
- cancel & delete job
- USS file/directory create & delete
- update `apis.md` to reflect additions

Signed-off-by: Trae Yelovich <[email protected]>
@traeok
chore: add license to new Go files
35816f7 
Signed-off-by: Trae Yelovich <[email protected]>
@traeok traeok marked this pull request as ready for review February 21, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkelosky dkelosky dkelosky left review comments

@t1m0thyj t1m0thyj Awaiting requested review from t1m0thyj

@zFernand0 zFernand0 Awaiting requested review from zFernand0

@jace-roell jace-roell Awaiting requested review from jace-roell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traeok @dkelosky