Fix/uss chown

[ATorrise]

WHAT IT DOES

• fixes the bug where zowex uss chown (zusf_chown_uss_file_or_dir) silently succeeded with exit code 0 when a non-existent/invalid user or group was supplied.
• Splits user:group correctly and validates both parts (numeric IDs or names via getpwnam/getgrnam), returning a clear error instead of passing -1 to chown()
• Adds a guard to reject the no-op case (neither user or group specified)
• Keeps current behavior of following symlinks (stat/chown); open question left in PR description whether we should switch to lstat/lchown in a follow-up for possibly safer/consisten behavior.

AUTOMATED TESTS

TEST PREP
Find values to test with

whoami      # copy this as YOUR_USER
id -Gn      # pick any one shown as YOUR_GROUP

# Use nosuchuser_xyz / nosuchgroup_xyz as obviously invalid values.

Create a test file

echo hello > demo.txt

TESTING (manual)

1. $\textcolor{red}{\text{Invalid user change → error}}$

zowex uss chown nosuchuser_xyz demo.txt ; echo  "rc=$?"

# Expected Output
chown error: invalid user 'nosuchuser_xyz'
rc=255
# Note: use a real file because path gets evaluated first and you will miss the user error!

2. $\textcolor{red}{\text{Invalid group change → error}}$

zowex uss chown YOUR_USER:nosuchgroup_xyz demo.txt ; echo "rc=$?"

# Expected Output
chown error: invalid group 'nosuchgroup_xyz'
rc=255

3. $\textcolor{green}{\text{Valid user change → success}}$

zowex uss chown YOUR_USER demo.txt ; echo "rc=$?"

# Expected Output
USS path 'demo.txt' owner changed to 'YOUR_USER'
rc=0

4. $\textcolor{green}{\text{Valid group-only change → success (if you own file and are in group)}}$

zowex uss chown :YOUR_GROUP demo.txt ; echo "rc=$?"

# Expected Output
USS path 'demo.txt' owner changed to ':YOUR_GROUP'
rc=0

5. $\textcolor{green}{\text{Valid user+group change → success (privilege dependent)}}$

zowex uss chown YOUR_USER:YOUR_GROUP demo.txt ; echo "rc=$?"

# Expected Output
USS path 'demo.txt' owner changed to 'YOUR_USER:YOUR_GROUP'
rc=0

6. $\textcolor{red}{\text{No-op (neither user nor group changed) → error}}$

zowex uss chown : demo.txt ; echo "rc=$?"

# Expected Output
chown error: neither user nor group specified
rc=255

7. $\textcolor{green}{\text{Directory recursive check → all nested files get new owner/group}}$

# Create a small file tree
mkdir -p project_dir/subdir1/subdir2
echo "first" > project_dir/file_top.txt
echo "second"  > project_dir/subdir1/file_mid.txt
echo "third" > project_dir/subdir1/subdir2/file_bottom.txt

# Change ownership recursively
zowex uss chown YOUR_USER:YOUR_GROUP project_dir --recursive ; echo "rc=$?"

# Verify all levels
ls -lR project_dir
# Expect all three files (and the dirs) to show YOUR_USER YOUR_GROUP

8. $\textcolor{green}{\text{Symlink check → follows link to target}}$
   (removal of this test case+ logic tbd)

# Create a real file and a symlink
echo "hello world" > real_target.txt
ln -s real_target.txt symlink_to_target.txt

# Change ownership using the symlink path
zowex uss chown YOUR_USER:YOUR_GROUP symlink_to_target.txt ; echo "rc=$?"

# Check that the real file’s ownership changed
ls -l real_target.txt    # should show YOUR_USER YOUR_GROUP

# Check the symlink shows the link
ls -l symlink_to_target.txt  # symlink still points to real_target.txt

REVIEW CHECKLIST
I certify that I have:

• tested my changes
• added/updated automated tests
• updated the changelog
• followed the contribution guidelines

ADDITIONAL COMMENTS

Important

Feedback is welcome on whether to switch to lstat/lchown in a future PR to avoid following symlinks.

[github-actions]

Client artifacts:

• CLI Plug-in: https://github.com/zowe/zowe-native-proto/actions/runs/18291904567/artifacts/4196254755
• VSCode Extension: https://github.com/zowe/zowe-native-proto/actions/runs/18291904567/artifacts/4196255021

[github-actions]

Server artifacts:

• PAX: https://github.com/zowe/zowe-native-proto/actions/runs/17980439080/artifacts/4094767235

[traeok]

Thanks for working on this Amber! I have a small request for modifying the function definition/declaration but the changes & test cases make sense to me.

Also, I noticed some of the files had formatting changes after saving on my end - you might want to run clang-format to adjust formatting - or you can install the "Clang" extension in VS Code and use that to install clang & run the formatter.

[sonarqubecloud]

Quality Gate failed

Failed conditions
6 Security Hotspots
15.1% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[t1m0thyj]

Please address compile errors in https://github.com/zowe/zowe-native-proto/actions/runs/18291904557/job/52080946497?pr=565